diff options
| author | Víctor Manuel Jáquez Leal <vjaquez@igalia.com> | 2018-02-14 13:42:53 +0100 |
|---|---|---|
| committer | Xiang, Haihao <haihao.xiang@intel.com> | 2018-03-14 12:09:44 +0800 |
| commit | 5802bd725347f7b6ee012e60f741508257e2ee76 (patch) | |
| tree | 9e64b46185baa9f3ab11c3b13e3ff82d331d6594 /src/i965_encoder_vp8.c | |
| parent | 41799e7bbc5933a9a28dfafb6d94bd32df77acfc (diff) | |
| download | libva-intel-driver-5802bd725347f7b6ee012e60f741508257e2ee76.tar.gz | |
Remove implicit truncations from int to bit-field
All the members in the structures scoreboard1 and scoreboard2 are
signed int of 4 bit long (this means they only admit values from
-8 to 7).
Along the code, these structures are assigned with values bigger
than 7 which are implicitly truncated to negative numbers. For
example, 0xF -> -1 or 0xE -> -2
It is better to explictly show the assigned values than rely on
implicit convertions. This patch aims to that direction.
Diffstat (limited to 'src/i965_encoder_vp8.c')
| -rw-r--r-- | src/i965_encoder_vp8.c | 32 |
1 files changed, 16 insertions, 16 deletions
diff --git a/src/i965_encoder_vp8.c b/src/i965_encoder_vp8.c index fdaeac0a..3ac68a0e 100644 --- a/src/i965_encoder_vp8.c +++ b/src/i965_encoder_vp8.c @@ -1448,34 +1448,34 @@ i965_encoder_vp8_gpe_context_vfe_scoreboard_init(struct i965_gpe_context *gpe_co gpe_context->vfe_desc5.scoreboard0.enable = scoreboard_params->enable; // Scoreboard 0 - gpe_context->vfe_desc6.scoreboard1.delta_x0 = 0xF; - gpe_context->vfe_desc6.scoreboard1.delta_y0 = 0x0; + gpe_context->vfe_desc6.scoreboard1.delta_x0 = -1; + gpe_context->vfe_desc6.scoreboard1.delta_y0 = 0; // Scoreboard 1 - gpe_context->vfe_desc6.scoreboard1.delta_x1 = 0x0; - gpe_context->vfe_desc6.scoreboard1.delta_y1 = 0xF; + gpe_context->vfe_desc6.scoreboard1.delta_x1 = 0; + gpe_context->vfe_desc6.scoreboard1.delta_y1 = -1; // Scoreboard 2 - gpe_context->vfe_desc6.scoreboard1.delta_x2 = 0x1; - gpe_context->vfe_desc6.scoreboard1.delta_y2 = 0xF; + gpe_context->vfe_desc6.scoreboard1.delta_x2 = 1; + gpe_context->vfe_desc6.scoreboard1.delta_y2 = -1; // Scoreboard 3 - gpe_context->vfe_desc6.scoreboard1.delta_x3 = 0xF; - gpe_context->vfe_desc6.scoreboard1.delta_y3 = 0xF; + gpe_context->vfe_desc6.scoreboard1.delta_x3 = -1; + gpe_context->vfe_desc6.scoreboard1.delta_y3 = -1; // Scoreboard 4 - gpe_context->vfe_desc7.scoreboard2.delta_x4 = 0xF; - gpe_context->vfe_desc7.scoreboard2.delta_y4 = 0x1; + gpe_context->vfe_desc7.scoreboard2.delta_x4 = -1; + gpe_context->vfe_desc7.scoreboard2.delta_y4 = 1; // Scoreboard 5 - gpe_context->vfe_desc7.scoreboard2.delta_x5 = 0x0; - gpe_context->vfe_desc7.scoreboard2.delta_y5 = 0xE; + gpe_context->vfe_desc7.scoreboard2.delta_x5 = 0; + gpe_context->vfe_desc7.scoreboard2.delta_y5 = -2; // Scoreboard 6 - gpe_context->vfe_desc7.scoreboard2.delta_x6 = 0x1; - gpe_context->vfe_desc7.scoreboard2.delta_y6 = 0xE; + gpe_context->vfe_desc7.scoreboard2.delta_x6 = 1; + gpe_context->vfe_desc7.scoreboard2.delta_y6 = -2; // Scoreboard 7 - gpe_context->vfe_desc7.scoreboard2.delta_x6 = 0xF; - gpe_context->vfe_desc7.scoreboard2.delta_y6 = 0xE; + gpe_context->vfe_desc7.scoreboard2.delta_x6 = -1; + gpe_context->vfe_desc7.scoreboard2.delta_y6 = -2; } static void |