diff options
| author | Milan Crha <mcrha@redhat.com> | 2018-06-25 16:15:41 +0200 |
|---|---|---|
| committer | Milan Crha <mcrha@redhat.com> | 2018-06-25 16:15:41 +0200 |
| commit | 2d4efd22ae39d862978ed1434286fe66d8577fa5 (patch) | |
| tree | a6d578acb297ae77637a2228877dc25fde3f3b35 /libsoup/soup-auth-digest.c | |
| parent | 8f77b47d11c95a28a120814cc87cd85d21dd106f (diff) | |
| download | libsoup-2d4efd22ae39d862978ed1434286fe66d8577fa5.tar.gz | |
soup-auth-digest: Fix buffer size issue found by Coverity Scan and clang
https://bugzilla.gnome.org/show_bug.cgi?id=781771
Diffstat (limited to 'libsoup/soup-auth-digest.c')
| -rw-r--r-- | libsoup/soup-auth-digest.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/libsoup/soup-auth-digest.c b/libsoup/soup-auth-digest.c index eda2a93c..e8ba9903 100644 --- a/libsoup/soup-auth-digest.c +++ b/libsoup/soup-auth-digest.c @@ -343,7 +343,7 @@ soup_auth_digest_compute_response (const char *method, g_checksum_update (checksum, (guchar *)method, strlen (method)); g_checksum_update (checksum, (guchar *)":", 1); g_checksum_update (checksum, (guchar *)uri, strlen (uri)); - strncpy (hex_a2, g_checksum_get_string (checksum), 33); + memcpy (hex_a2, g_checksum_get_string (checksum), sizeof (char) * 33); g_checksum_free (checksum); /* compute KD */ @@ -369,7 +369,7 @@ soup_auth_digest_compute_response (const char *method, } g_checksum_update (checksum, (guchar *)hex_a2, 32); - strncpy (response, g_checksum_get_string (checksum), 33); + memcpy (response, g_checksum_get_string (checksum), sizeof (char) * 33); g_checksum_free (checksum); } |