From 2d4efd22ae39d862978ed1434286fe66d8577fa5 Mon Sep 17 00:00:00 2001 From: Milan Crha Date: Mon, 25 Jun 2018 16:15:41 +0200 Subject: soup-auth-digest: Fix buffer size issue found by Coverity Scan and clang https://bugzilla.gnome.org/show_bug.cgi?id=781771 --- libsoup/soup-auth-digest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'libsoup/soup-auth-digest.c') diff --git a/libsoup/soup-auth-digest.c b/libsoup/soup-auth-digest.c index eda2a93c..e8ba9903 100644 --- a/libsoup/soup-auth-digest.c +++ b/libsoup/soup-auth-digest.c @@ -343,7 +343,7 @@ soup_auth_digest_compute_response (const char *method, g_checksum_update (checksum, (guchar *)method, strlen (method)); g_checksum_update (checksum, (guchar *)":", 1); g_checksum_update (checksum, (guchar *)uri, strlen (uri)); - strncpy (hex_a2, g_checksum_get_string (checksum), 33); + memcpy (hex_a2, g_checksum_get_string (checksum), sizeof (char) * 33); g_checksum_free (checksum); /* compute KD */ @@ -369,7 +369,7 @@ soup_auth_digest_compute_response (const char *method, } g_checksum_update (checksum, (guchar *)hex_a2, 32); - strncpy (response, g_checksum_get_string (checksum), 33); + memcpy (response, g_checksum_get_string (checksum), sizeof (char) * 33); g_checksum_free (checksum); } -- cgit v1.2.1