drop expr syntax error in make check under dash

Submitted by: Elia Pinto

2 files changed, 3 insertions, 2 deletions

diff --git a/CHANGES b/CHANGES
index d30682c..fac0c4c 100644
--- a/CHANGES
+++ b/CHANGES
@@ -1,4 +1,5 @@
 1.17 -> 2.0:
+    - devzero2000: drop expr syntax error in make check under dash
     - devzero2000: Print to the end of the configure phase the options we have
       enabled and their results on the basis of the target system
     - devzero2000: fail autogen.sh if autoreconf fail 
diff --git a/testit.sh b/testit.sh
index dc14e7a..0af5f48 100755
--- a/testit.sh
+++ b/testit.sh
@@ -30,10 +30,10 @@ if [ -z "${valgrind_environment}" ]
 then
 	MALLOC_CHECK_=3
 	export MALLOC_CHECK_
-	MALLOC_PERTURB_=`expr \( $RANDOM % 255 \) + 1 `
+	[ -n "${RANDOM}" ] && MALLOC_PERTURB_=`expr \( $RANDOM % 255 \) + 1 `
 	export MALLOC_PERTURB_
 	#
-	if [ -z "${MALLOC_PERTURB_}" ]  # XXX: some shell don't have RANDOM ?
+	if [ -z "${MALLOC_PERTURB_}" ]  # RANDOM is a bashism
 	then
 		r=`ps -ef | cksum | cut -f1 -d" " 2>/dev/null`
 		[ -z "${r}" ] && r=1234567890