1 files changed, 47 insertions, 56 deletions

diff --git a/src/test/libical-glib/parameter.py b/src/test/libical-glib/parameter.py
index 5a0c6230..17f2aa06 100755..100644
--- a/src/test/libical-glib/parameter.py
+++ b/src/test/libical-glib/parameter.py
@@ -1,72 +1,63 @@
 #!/usr/bin/env python3
-#GI_TYPELIB_PATH=$PREFIX/lib/girepository-1.0/ ./parameter.py
+# GI_TYPELIB_PATH=$PREFIX/lib/girepository-1.0/ ./parameter.py
 
 ###############################################################################
 #
-# Copyright (C) 2015 William Yu <williamyu@gnome.org>
+# SPDX-FileCopyrightText: 2015 William Yu <williamyu@gnome.org>
 #
-# This library is free software; you can redistribute it and/or modify
-# it under the terms of either:
-#
-#   The LGPL as published by the Free Software Foundation, version
-#   2.1, available at: https://www.gnu.org/licenses/lgpl-2.1.txt
-#
-# Or:
-#
-#   The Mozilla Public License Version 2.0. You may obtain a copy of
-#   the License at https://www.mozilla.org/MPL/
+# SPDX-License-Identifier: LGPL-2.1-only OR MPL-2.0
 #
 ###############################################################################
 
-import gi
+''' Test Python bindings for Libical parameter '''
 
+import gi
 gi.require_version('ICalGLib', '3.0')
-
-from gi.repository import ICalGLib
+from gi.repository import ICalGLib  # nopep8 # pylint: disable=wrong-import-position
 
 # Test interaction with gchar
-altrep = "This is an altrep";
-parameter = ICalGLib.Parameter.new_altrep(altrep);
-retrieved_altrep = parameter.get_altrep();
-assert(retrieved_altrep == altrep);
-another_altrep = "This is an another altrep";
-parameter.set_altrep(another_altrep);
-retrieved_altrep = parameter.get_altrep();
-assert(retrieved_altrep == another_altrep);
+altrep = "This is an altrep"
+parameter = ICalGLib.Parameter.new_altrep(altrep)
+retrievedAltrep = parameter.get_altrep()
+assert retrievedAltrep == altrep
+anotherAltrep = "This is an another altrep"
+parameter.set_altrep(anotherAltrep)
+retrievedAltrep = parameter.get_altrep()
+assert retrievedAltrep == anotherAltrep
 
 # Test interaction with enum
-action = ICalGLib.ParameterAction.X;
-parameter = ICalGLib.Parameter.new_actionparam(action);
-retrieved_action = parameter.get_actionparam();
-assert(retrieved_action == action);
-action = ICalGLib.ParameterAction.ASK;
-parameter.set_actionparam(action);
-retrieved_action = parameter.get_actionparam();
-assert(retrieved_action == action);
+action = ICalGLib.ParameterAction.X
+parameter = ICalGLib.Parameter.new_actionparam(action)
+retrievedAction = parameter.get_actionparam()
+assert retrievedAction == action
+action = ICalGLib.ParameterAction.ASK
+parameter.set_actionparam(action)
+retrievedAction = parameter.get_actionparam()
+assert retrievedAction == action
 
 # Test general utilities
-kind = ICalGLib.ParameterKind.ACTIONPARAM_PARAMETER;
-parameter = ICalGLib.Parameter.new(kind);
-assert(parameter.isa() == kind);
-assert(parameter.isa_parameter() == 1);
-string = parameter.as_ical_string();
-assert(string == None);
-clone = parameter.clone();
-assert(clone.isa() == kind);
-assert(clone.isa_parameter() == 1);
-string = clone.as_ical_string();
-assert(string == None);
-
-string = ICalGLib.Parameter.kind_to_string(kind);
-assert(string == "ACTIONPARAM");
-assert(ICalGLib.Parameter.kind_from_string(string) == kind);
-
-value = "This is a value";
-typevalue = string + "=" + value;
-parameter = ICalGLib.Parameter.new_from_string(typevalue);
-assert(parameter.as_ical_string() == typevalue);
-assert(parameter.isa() == kind);
-assert(parameter.isa_parameter() == 1);
-
-another_parameter = ICalGLib.Parameter.new_from_value_string(kind, value);
-assert(another_parameter.as_ical_string() == typevalue);
+kind = ICalGLib.ParameterKind.ACTIONPARAM_PARAMETER
+parameter = ICalGLib.Parameter.new(kind)
+assert parameter.isa() == kind
+assert parameter.isa_parameter() == 1
+string = parameter.as_ical_string()
+assert string is None
+clone = parameter.clone()
+assert clone.isa() == kind
+assert clone.isa_parameter() == 1
+string = clone.as_ical_string()
+assert string is None
+
+string = ICalGLib.Parameter.kind_to_string(kind)
+assert string == "ACTIONPARAM"
+assert ICalGLib.Parameter.kind_from_string(string) == kind
+
+value = "This is a value"
+typevalue = string + "=" + value
+parameter = ICalGLib.Parameter.new_from_string(typevalue)
+assert parameter.as_ical_string() == typevalue
+assert parameter.isa() == kind
+assert parameter.isa_parameter() == 1
+
+anotherParameter = ICalGLib.Parameter.new_from_value_string(kind, value)
+assert anotherParameter.as_ical_string() == typevalue