diff options
| author | Hans Ulrich Niedermann <hun@n-dimensional.de> | 2021-10-05 15:50:32 +0200 |
|---|---|---|
| committer | Hans Ulrich Niedermann <hun@n-dimensional.de> | 2021-10-05 16:07:20 +0200 |
| commit | 0dbeaf7cbf30ab88ac7aea3e7d3f24df8dc0309f (patch) | |
| tree | 5473eb1125e904a86e479180689167280a2e81dc /camlibs/pccam600 | |
| parent | bacd4128617e1dd613998c0268ded8304cef6f19 (diff) | |
| download | libgphoto2-0dbeaf7cbf30ab88ac7aea3e7d3f24df8dc0309f.tar.gz | |
Use consistently named non-reserved CPP macros for header files
C preprocessor macros beginning/ending with underscores are
reserved for system use as well as macros containing a double
underscore anywhere, so application software macros are
supposed to be named differently.
For a header file gphoto2-abilities-list.h, this
consistently uses a macro name
LIBGPHOTO2_GPHOTO2_ABILITIES_LIST_H
for the usual
#ifndef LIBGPHOTO2_GPHOTO2_ABILITIES_LIST_H
#define LIBGPHOTO2_GPHOTO2_ABILITIES_LIST_H
... content of the header file ...
#endif /* !defined(LIBGPHOTO2_GPHOTO2_ABILITIES_LIST_H) */
Found using "clang -Weverything".
This should work, unless when run with an ancient C preprocessor
which might only the first 8 or 10 characters to distinguish
macro names and ignores the remainder of the name.
Diffstat (limited to 'camlibs/pccam600')
| -rw-r--r-- | camlibs/pccam600/pccam600.h | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/camlibs/pccam600/pccam600.h b/camlibs/pccam600/pccam600.h index 42d7a46db..6a4b574b2 100644 --- a/camlibs/pccam600/pccam600.h +++ b/camlibs/pccam600/pccam600.h @@ -13,8 +13,8 @@ * Author: Peter Kajberg <pbk@odense.kollegienet.dk> */ -#ifndef __PCCAM600_H__ -#define __PCCAM600_H__ +#ifndef CAMLIBS_PCCAM600_PCCAM600_H +#define CAMLIBS_PCCAM600_PCCAM600_H #include <gphoto2/gphoto2.h> #include <gphoto2/gphoto2-port.h> @@ -43,5 +43,6 @@ int pccam600_read_data(GPPort *port, unsigned char *buffer); int pccam600_get_file(GPPort *port, GPContext *context, int index); int pccam600_get_mem_info(GPPort *port, GPContext *context, int *totalmem, int *freemem); -#endif /* __PCCAM600_H__ */ + +#endif /* !defined(CAMLIBS_PCCAM600_PCCAM600_H) */ |