summaryrefslogtreecommitdiff
path: root/.github
diff options
context:
space:
mode:
authorHans Ulrich Niedermann <hun@n-dimensional.de>2022-01-19 16:01:53 +0100
committerHans Ulrich Niedermann <hun@n-dimensional.de>2022-01-22 17:47:01 +0100
commitbd5aec38d1ef2320b41d8f5404bbfaf80444936b (patch)
treec4e7707b34d88a9f0b3a6ad5ef5b764a2e81e305 /.github
parent3fa40feb460f37c569b4197cc8712196266b88dd (diff)
downloadlibgphoto2-bd5aec38d1ef2320b41d8f5404bbfaf80444936b.tar.gz
pc files: Fix gphoto2 builds, avoid builds with wrong headers
In the *.pc files, use a C preprocessor include path both with and without the gphoto2/ path component: Cflags: -I${includedir} -I${includedir}/gphoto2 This allows both the preferred way to include gphoto2 headers #include <gphoto2/gphoto2.h> #include <gphoto2/gphoto2-camera.h> and also the early 2000s legacy way (still in use by kamera and others because we did not properly communicate and enforce that back when we were still stabilizing the API) #include <gphoto2.h> #include <gphoto2-camera.h> to produce builds with the libgphoto2 headers actually corresponding to the *.pc files in use. Any other option for the *.pc file Cflags either produces unintended build failures or builds which use the wrong header files (the `-I${includedir}/gphoto2` option), or breaks the `#include <...>` part of the libgphoto2 API from the early 2000s still in use by kamera and others (the `-I${includedir}` option). For details, see https://github.com/gphoto/libgphoto2/issues/717 and https://github.com/gphoto/libgphoto2/issues/717#issuecomment-1018040615 Fixes: https://github.com/gphoto/libgphoto2/issues/717
Diffstat (limited to '.github')
0 files changed, 0 insertions, 0 deletions