diff options
| author | Ramsay Jones <ramsay@ramsay1.demon.co.uk> | 2010-06-01 19:37:10 +0100 |
|---|---|---|
| committer | Andreas Ericsson <ae@op5.se> | 2010-06-02 11:18:56 +0200 |
| commit | 28f9832928c52e08c7db5a0d31fde054f51fc475 (patch) | |
| tree | db01475e9527b251dc429b03a96ecfdb2928aa1d /src/commit.c | |
| parent | c1b62b2eded035d22584c427487503335f519d4c (diff) | |
| download | libgit2-28f9832928c52e08c7db5a0d31fde054f51fc475.tar.gz | |
Fix inconsistent definition of off_t on Linux
In order to avoid inconsistent definitions of type off_t, all
compilation units should include the "common.h" header file
before certain system headers (those which directly or indirectly
lead to the definition of off_t). The "common.h" header contains
the definition of _FILE_OFFSET_BITS to select 64-bit file offsets.
The symptom of this inconsistency, while compiling with -Wextra, is
the following warning:
In file included from src/common.h:50,
from src/commit.c:28:
src/util.h: In function git__is_sizet:
src/util.h:41: warning: comparison between signed and unsigned
In order to fix the problem, we simply remove the #include <time.h>
statement at the head of src/commit.c. Note that src/commit.h also
includes <time.h>.
Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Signed-off-by: Andreas Ericsson <ae@op5.se>
Diffstat (limited to 'src/commit.c')
| -rw-r--r-- | src/commit.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/commit.c b/src/commit.c index 6110c8944..0db888dbd 100644 --- a/src/commit.c +++ b/src/commit.c @@ -23,8 +23,6 @@ * Boston, MA 02110-1301, USA. */ -#include <time.h> - #include "common.h" #include "commit.h" #include "revwalk.h" |