From 28f9832928c52e08c7db5a0d31fde054f51fc475 Mon Sep 17 00:00:00 2001 From: Ramsay Jones Date: Tue, 1 Jun 2010 19:37:10 +0100 Subject: Fix inconsistent definition of off_t on Linux In order to avoid inconsistent definitions of type off_t, all compilation units should include the "common.h" header file before certain system headers (those which directly or indirectly lead to the definition of off_t). The "common.h" header contains the definition of _FILE_OFFSET_BITS to select 64-bit file offsets. The symptom of this inconsistency, while compiling with -Wextra, is the following warning: In file included from src/common.h:50, from src/commit.c:28: src/util.h: In function git__is_sizet: src/util.h:41: warning: comparison between signed and unsigned In order to fix the problem, we simply remove the #include statement at the head of src/commit.c. Note that src/commit.h also includes . Signed-off-by: Ramsay Jones Signed-off-by: Andreas Ericsson --- src/commit.c | 2 -- 1 file changed, 2 deletions(-) (limited to 'src/commit.c') diff --git a/src/commit.c b/src/commit.c index 6110c8944..0db888dbd 100644 --- a/src/commit.c +++ b/src/commit.c @@ -23,8 +23,6 @@ * Boston, MA 02110-1301, USA. */ -#include - #include "common.h" #include "commit.h" #include "revwalk.h" -- cgit v1.2.1