diff options
author | Edward Thomson <ethomson@edwardthomson.com> | 2018-03-23 07:38:34 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-03-23 07:38:34 -0700 |
commit | 6311e886d8b5377c6037cd9937ccf66a71f3361d (patch) | |
tree | aab5ab0ee9bfaeae3b6c9f36b1032aa4bb59e7fd | |
parent | 72e60347ffc4383091d4b74f8f42ee6233c8a654 (diff) | |
parent | a52b4c51c0a7de341f5b2cef48ac6d7c8b9476e1 (diff) | |
download | libgit2-6311e886d8b5377c6037cd9937ccf66a71f3361d.tar.gz |
Merge pull request #4594 from pks-t/pks/mempack-assertv0.27.0
odb: fix writing to fake write streams
-rw-r--r-- | src/odb.c | 2 | ||||
-rw-r--r-- | tests/odb/backend/mempack.c | 60 |
2 files changed, 61 insertions, 1 deletions
@@ -369,7 +369,7 @@ static int fake_wstream__write(git_odb_stream *_stream, const char *data, size_t { fake_wstream *stream = (fake_wstream *)_stream; - assert(stream->written + len > stream->size); + assert(stream->written + len <= stream->size); memcpy(stream->buffer + stream->written, data, len); stream->written += len; diff --git a/tests/odb/backend/mempack.c b/tests/odb/backend/mempack.c new file mode 100644 index 000000000..624f0e604 --- /dev/null +++ b/tests/odb/backend/mempack.c @@ -0,0 +1,60 @@ +#include "clar_libgit2.h" +#include "repository.h" +#include "backend_helpers.h" +#include "git2/sys/mempack.h" + +static git_odb *_odb; +static git_oid _oid; +static git_odb_object *_obj; +static git_repository *_repo; + +void test_odb_backend_mempack__initialize(void) +{ + git_odb_backend *backend; + + cl_git_pass(git_mempack_new(&backend)); + cl_git_pass(git_odb_new(&_odb)); + cl_git_pass(git_odb_add_backend(_odb, backend, 10)); + cl_git_pass(git_repository_wrap_odb(&_repo, _odb)); +} + +void test_odb_backend_mempack__cleanup(void) +{ + git_odb_object_free(_obj); + git_odb_free(_odb); + git_repository_free(_repo); +} + +void test_odb_backend_mempack__write_succeeds(void) +{ + const char *data = "data"; + cl_git_pass(git_odb_write(&_oid, _odb, data, strlen(data) + 1, GIT_OBJ_BLOB)); + cl_git_pass(git_odb_read(&_obj, _odb, &_oid)); +} + +void test_odb_backend_mempack__read_of_missing_object_fails(void) +{ + cl_git_pass(git_oid_fromstr(&_oid, "f6ea0495187600e7b2288c8ac19c5886383a4633")); + cl_git_fail_with(GIT_ENOTFOUND, git_odb_read(&_obj, _odb, &_oid)); +} + +void test_odb_backend_mempack__exists_of_missing_object_fails(void) +{ + cl_git_pass(git_oid_fromstr(&_oid, "f6ea0495187600e7b2288c8ac19c5886383a4633")); + cl_assert(git_odb_exists(_odb, &_oid) == 0); +} + +void test_odb_backend_mempack__exists_with_existing_objects_succeeds(void) +{ + const char *data = "data"; + cl_git_pass(git_odb_write(&_oid, _odb, data, strlen(data) + 1, GIT_OBJ_BLOB)); + cl_assert(git_odb_exists(_odb, &_oid) == 1); +} + +void test_odb_backend_mempack__blob_create_frombuffer_succeeds(void) +{ + const char *data = "data"; + + cl_git_pass(git_blob_create_frombuffer(&_oid, _repo, data, strlen(data) + 1)); + cl_assert(git_odb_exists(_odb, &_oid) == 1); +} |