diff options
| author | Ben Straub <bs@github.com> | 2013-11-01 19:22:43 -0700 |
|---|---|---|
| committer | Ben Straub <bs@github.com> | 2013-11-01 19:22:43 -0700 |
| commit | 56c1cda28a4b33fb305d99a2c7985a37efd3839d (patch) | |
| tree | 36f166c07d9dd69ba801f4e7774d818bd07b4ed7 | |
| parent | 7e0359084ef0faba8f458f9cccad2dc8f5baf800 (diff) | |
| download | libgit2-56c1cda28a4b33fb305d99a2c7985a37efd3839d.tar.gz | |
Clarify parsing issues and errors
| -rw-r--r-- | src/netops.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/netops.c b/src/netops.c index 0bf3a8f13..d2acdb240 100644 --- a/src/netops.c +++ b/src/netops.c @@ -674,7 +674,8 @@ int gitno_extract_url_parts( * ==> [user[:pass]@]hostname.tld[:port]/resource */ - /* Check for user and maybe password */ + /* Check for user and maybe password. Note that this deviates from RFC-1738 + * in that it allows non-encoded colons in the password field. */ at = strchr(url, '@'); if (at) { colon = strchr(url, ':'); @@ -695,7 +696,7 @@ int gitno_extract_url_parts( colon = strchr(url, ':'); if (!slash || (colon && (slash < colon))) { - giterr_set(GITERR_NET, "Malformed URL"); + giterr_set(GITERR_NET, "Malformed URL: %s", url); return GIT_EINVALIDSPEC; } |