summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEdward Thomson <ethomson@edwardthomson.com>2019-06-16 00:10:02 +0100
committerEdward Thomson <ethomson@edwardthomson.com>2019-06-16 00:55:14 +0100
commite45350feab198e2e29559f7e30331e81ca4cba86 (patch)
treed7a73f24f2d26c7273b3920104cef16ffc601e2c
parent6574cd00763c57cef39ad3d0a9df323904d37864 (diff)
downloadlibgit2-ethomson/to_from.tar.gz
tag: add underscore to `from` functionethomson/to_from
The majority of functions are named `from_something` (with an underscore) instead of `fromsomething`. Update the tag function for consistency with the rest of the library.
-rw-r--r--include/git2/deprecated.h6
-rw-r--r--include/git2/tag.h2
-rw-r--r--src/tag.c9
3 files changed, 15 insertions, 2 deletions
diff --git a/include/git2/deprecated.h b/include/git2/deprecated.h
index 8e0966d6b..394072461 100644
--- a/include/git2/deprecated.h
+++ b/include/git2/deprecated.h
@@ -291,6 +291,12 @@ GIT_EXTERN(int) git_index_add_frombuffer(
#define GIT_REF_FORMAT_REFSPEC_PATTERN GIT_REFERENCE_FORMAT_REFSPEC_PATTERN
#define GIT_REF_FORMAT_REFSPEC_SHORTHAND GIT_REFERENCE_FORMAT_REFSPEC_SHORTHAND
+GIT_EXTERN(int) git_tag_create_frombuffer(
+ git_oid *oid,
+ git_repository *repo,
+ const char *buffer,
+ int force);
+
/**@}*/
/** @name Deprecated Credential Callback Types
diff --git a/include/git2/tag.h b/include/git2/tag.h
index c2d490d26..4e5fe1db1 100644
--- a/include/git2/tag.h
+++ b/include/git2/tag.h
@@ -217,7 +217,7 @@ GIT_EXTERN(int) git_tag_annotation_create(
* @param force Overwrite existing tags
* @return 0 on success; error code otherwise
*/
-GIT_EXTERN(int) git_tag_create_frombuffer(
+GIT_EXTERN(int) git_tag_create_from_buffer(
git_oid *oid,
git_repository *repo,
const char *buffer,
diff --git a/src/tag.c b/src/tag.c
index 42c4e99ad..a7a005ca1 100644
--- a/src/tag.c
+++ b/src/tag.c
@@ -328,7 +328,7 @@ int git_tag_create_lightweight(
return git_tag_create__internal(oid, repo, tag_name, target, NULL, NULL, allow_ref_overwrite, 0);
}
-int git_tag_create_frombuffer(git_oid *oid, git_repository *repo, const char *buffer, int allow_ref_overwrite)
+int git_tag_create_from_buffer(git_oid *oid, git_repository *repo, const char *buffer, int allow_ref_overwrite)
{
git_tag tag;
int error;
@@ -521,3 +521,10 @@ int git_tag_peel(git_object **tag_target, const git_tag *tag)
{
return git_object_peel(tag_target, (const git_object *)tag, GIT_OBJECT_ANY);
}
+
+/* Deprecated Functions */
+
+int git_tag_create_frombuffer(git_oid *oid, git_repository *repo, const char *buffer, int allow_ref_overwrite)
+{
+ return git_tag_create_from_buffer(oid, repo, buffer, allow_ref_overwrite);
+}