diff options
| author | Edward Thomson <ethomson@edwardthomson.com> | 2020-12-14 10:43:07 +0000 |
|---|---|---|
| committer | Edward Thomson <ethomson@edwardthomson.com> | 2020-12-14 10:43:07 +0000 |
| commit | 589b8129e065b0bcfdbb7c4eee815b6e149218bc (patch) | |
| tree | 4e59ad57f677ca533b3f57a83a37b3e28b9beccd | |
| parent | 89ffa98eacde35b045b16586be196dc2ca89ab0c (diff) | |
| download | libgit2-cmn/rc4.tar.gz | |
badssl: RC4 should not fail with ECERTIFICATEcmn/rc4
Using RC4 is not a _certificate_ problem, it's a cipher problem. The
SSL implementation should and will fail with an unrecoverable error
(-1). There's no opportunity to accept/continue.
| -rw-r--r-- | tests/online/badssl.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/tests/online/badssl.c b/tests/online/badssl.c index ffd4ef126..6735e9cdb 100644 --- a/tests/online/badssl.c +++ b/tests/online/badssl.c @@ -70,8 +70,6 @@ void test_online_badssl__old_cipher(void) if (!g_has_ssl) cl_skip(); - cl_git_fail_with(GIT_ECERTIFICATE, - git_clone(&g_repo, "https://rc4.badssl.com/fake.git", "./fake", NULL)); - cl_git_fail_with(GIT_ECERTIFICATE, - git_clone(&g_repo, "https://rc4.badssl.com/fake.git", "./fake", &opts)); + cl_git_fail(git_clone(&g_repo, "https://rc4.badssl.com/fake.git", "./fake", NULL)); + cl_git_fail(git_clone(&g_repo, "https://rc4.badssl.com/fake.git", "./fake", &opts)); } |