summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCarlos Martín Nieto <cmn@dwim.me>2016-03-09 11:16:16 +0100
committerCarlos Martín Nieto <cmn@dwim.me>2016-03-09 11:16:16 +0100
commitd50fd57174f98b7786a5d2ae13df5d98b07e81ee (patch)
tree4e19835a3cb757961b43dba9351da390b43e7efc
parentc68044a8797d6eac5c8468dd5bec53d07b3ad66c (diff)
downloadlibgit2-cmn/mwindow-try-harder.tar.gz
mwindow: free unused windows if we fail to mmapcmn/mwindow-try-harder
The first time may be due to memory fragmentation or just bad luck on a 32-bit system. When we hit the mmap error for the first time, free up the unused windows and try again.
-rw-r--r--src/mwindow.c14
1 files changed, 12 insertions, 2 deletions
diff --git a/src/mwindow.c b/src/mwindow.c
index 55c8d894b..d3e9be78b 100644
--- a/src/mwindow.c
+++ b/src/mwindow.c
@@ -296,8 +296,18 @@ static git_mwindow *new_window(
*/
if (git_futils_mmap_ro(&w->window_map, fd, w->offset, (size_t)len) < 0) {
- git__free(w);
- return NULL;
+ /*
+ * The first error might be down to memory fragmentation even if
+ * we're below our soft limits, so free up what we can and try again.
+ */
+
+ while (git_mwindow_close_lru(mwf) == 0)
+ /* nop */;
+
+ if (git_futils_mmap_ro(&w->window_map, fd, w->offset, (size_t)len) < 0) {
+ git__free(w);
+ return NULL;
+ }
}
ctl->mmap_calls++;