Changes to apr_generate_random_bytes:

- use apr_size_t for buffer size (please check on non-Unix platforms)
- rewrite DEV_RANDOM implementation to re-open if an EOF is received
(rather than go into an infinite loop), to cope with the odd
/dev/random implementation on BSD/OS 4.1. Also don't leak the fd if the
read() fails, and fix a warning with gcc -Wsign-compare.


git-svn-id: http://svn.apache.org/repos/asf/apr/apr/trunk@64166 13f79535-47bb-0310-9956-ffa450edef68

1 files changed, 3 insertions, 3 deletions

diff --git a/include/apr_general.h b/include/apr_general.h
index c81af684c..03574e64c 100644
--- a/include/apr_general.h
+++ b/include/apr_general.h
@@ -262,12 +262,12 @@ APR_DECLARE(void) apr_terminate2(void);
 
 /* TODO: I'm not sure this is the best place to put this prototype...*/
 /**
- * Generate a string of random bytes.
+ * Generate random bytes.
  * @param buf Random bytes go here
- * @param length size of the buffer
+ * @param length number of bytes to read
  */
 APR_DECLARE(apr_status_t) apr_generate_random_bytes(unsigned char * buf, 
-                                                    int length);
+                                                    apr_size_t length);
 
 #endif
 /** @} */