summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorjorton <jorton@13f79535-47bb-0310-9956-ffa450edef68>2004-05-27 16:00:05 +0000
committerjorton <jorton@13f79535-47bb-0310-9956-ffa450edef68>2004-05-27 16:00:05 +0000
commitc25825da968e2f2ef6c7ade94ae86fe257cc8b54 (patch)
treeeb20da43f2137fd9a4cf70c4812e9f78edabb9ff
parentd0ea338a4f23feaad0942e9efb029b1e9fe9daf8 (diff)
downloadlibapr-c25825da968e2f2ef6c7ade94ae86fe257cc8b54.tar.gz
* shmem/unix/shm.c (apr_shm_create): Answer some FIXMEs: wrong, yes, no.
git-svn-id: http://svn.apache.org/repos/asf/apr/apr/trunk@65135 13f79535-47bb-0310-9956-ffa450edef68
-rw-r--r--shmem/unix/shm.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/shmem/unix/shm.c b/shmem/unix/shm.c
index e78ea1113..f76d3c180 100644
--- a/shmem/unix/shm.c
+++ b/shmem/unix/shm.c
@@ -254,8 +254,7 @@ APR_DECLARE(apr_status_t) apr_shm_create(apr_shm_t **m,
}
#endif /* APR_USE_SHMEM_MMAP_TMP */
#if APR_USE_SHMEM_MMAP_SHM
- /* FIXME: Is APR_OS_DEFAULT sufficient? */
- tmpfd = shm_open(filename, O_RDWR | O_CREAT | O_EXCL, APR_OS_DEFAULT);
+ tmpfd = shm_open(filename, O_RDWR | O_CREAT | O_EXCL, 0644);
if (tmpfd == -1) {
return errno;
}
@@ -277,7 +276,6 @@ APR_DECLARE(apr_status_t) apr_shm_create(apr_shm_t **m,
/* FIXME: check for errors */
- /* FIXME: Is it ok to close this file when using shm_open?? */
status = apr_file_close(file);
if (status != APR_SUCCESS) {
return status;
@@ -462,7 +460,6 @@ APR_DECLARE(apr_status_t) apr_shm_attach(apr_shm_t **m,
new_m = apr_palloc(pool, sizeof(apr_shm_t));
- /* FIXME: does APR_OS_DEFAULT matter for reading? */
status = apr_file_open(&file, filename,
APR_READ, APR_OS_DEFAULT, pool);
if (status != APR_SUCCESS) {