diff options
author | Lucas De Marchi <lucas.de.marchi@gmail.com> | 2022-06-03 13:49:01 -0700 |
---|---|---|
committer | Lucas De Marchi <lucas.de.marchi@gmail.com> | 2022-06-26 23:21:44 -0700 |
commit | 07bf5e1520ebf520a65f350a99d6a7f28c482ab5 (patch) | |
tree | 44b62dbed49c281f43b262e3bac19a30d01948b8 | |
parent | ea3c8adfd39a5f6137482daca21058132ec5ee8d (diff) | |
download | kmod-07bf5e1520ebf520a65f350a99d6a7f28c482ab5.tar.gz |
depmod: Fix writing over array length
Make sure return value in flush_stream_to() is the length written
if the value didn't the size. Fix warning on gcc 12.1:
tools/depmod.c: In function ‘output_builtin_alias_bin’:
tools/depmod.c:2465:24: warning: array subscript 4096 is above array bounds of ‘char[4096]’ [-Warray-bounds]
2465 | modname[len] = '\0';
| ~~~~~~~^~~~~
tools/depmod.c:2460:22: note: while referencing ‘modname’
2460 | char modname[PATH_MAX];
| ^~~~~~~
tools/depmod.c:2477:22: warning: array subscript 4096 is above array bounds of ‘char[4096]’ [-Warray-bounds]
2477 | value[len] = '\0';
| ~~~~~^~~~~
tools/depmod.c:2461:22: note: while referencing ‘value’
2461 | char value[PATH_MAX];
| ^~~~~
Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>
-rw-r--r-- | tools/depmod.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/tools/depmod.c b/tools/depmod.c index 4117dd1..364b7d4 100644 --- a/tools/depmod.c +++ b/tools/depmod.c @@ -2430,6 +2430,7 @@ static int flush_stream_to(FILE *in, int endchar, char *dst, size_t dst_sz) if (i == dst_sz) { WRN("Could not flush stream: %d. Partial content: %.*s\n", ENOSPC, (int) dst_sz, dst); + i--; } return c == endchar ? i : 0; |