diff options
author | Arturo Bernal <arturobernalg@gmail.com> | 2021-10-02 16:41:11 +0200 |
---|---|---|
committer | Arturo Bernal <arturobernalg@gmail.com> | 2021-10-03 13:41:15 +0200 |
commit | 6718c526a8be707af73e726cda559c7f1374586a (patch) | |
tree | 611271dc8a9c2884de4e86606b82f645f74072c8 | |
parent | a392d5a74dbdd1831a981d41d29ab1a6b4945e62 (diff) | |
download | ant-6718c526a8be707af73e726cda559c7f1374586a.tar.gz |
Use Bulk operation instead of iteration.
5 files changed, 6 insertions, 7 deletions
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/ejb/WeblogicDeploymentTool.java b/src/main/org/apache/tools/ant/taskdefs/optional/ejb/WeblogicDeploymentTool.java index 1f66ce0c5..018156be8 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/ejb/WeblogicDeploymentTool.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/ejb/WeblogicDeploymentTool.java @@ -470,7 +470,7 @@ public class WeblogicDeploymentTool extends GenericDeploymentTool { try (InputStream in = Files.newInputStream(weblogicDD.toPath())) { saxParser.parse(new InputSource(in), handler); } - handler.getFiles().forEach(ejbFiles::put); + ejbFiles.putAll(handler.getFiles()); } catch (Exception e) { throw new BuildException( "Exception while adding Vendor specific files: " diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitTask.java b/src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitTask.java index ef1e293d7..2f6b42e43 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitTask.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitTask.java @@ -1220,7 +1220,7 @@ public class JUnitTask extends Task { + propsFile.getAbsolutePath()); final Hashtable<String, Object> p = getProject().getProperties(); final Properties props = new Properties(); - p.forEach(props::put); + props.putAll(p); try { final OutputStream outstream = Files.newOutputStream(propsFile.toPath()); props.store(outstream, "Ant JUnitTask generated properties file"); diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitTest.java b/src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitTest.java index d321bdc2a..1646b7dd1 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitTest.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitTest.java @@ -472,7 +472,7 @@ public class JUnitTest extends BaseTest implements Cloneable { */ public void setProperties(Hashtable<?, ?> p) { props = new Properties(); - p.forEach(props::put); + props.putAll(p); } /** diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitTestRunner.java b/src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitTestRunner.java index 971fa7d47..8c35e9d52 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitTestRunner.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitTestRunner.java @@ -981,7 +981,7 @@ public class JUnitTestRunner implements TestListener, JUnitTaskMirror.JUnitTestR } // Add/overlay system properties on the properties from the Ant project - System.getProperties().forEach(props::put); + props.putAll(System.getProperties()); int returnCode = SUCCESS; if (multipleTests) { diff --git a/src/main/org/apache/tools/tar/TarOutputStream.java b/src/main/org/apache/tools/tar/TarOutputStream.java index ccf1f42e2..76460e951 100644 --- a/src/main/org/apache/tools/tar/TarOutputStream.java +++ b/src/main/org/apache/tools/tar/TarOutputStream.java @@ -29,6 +29,7 @@ import java.io.OutputStream; import java.io.StringWriter; import java.nio.ByteBuffer; import java.nio.charset.StandardCharsets; +import java.util.Arrays; import java.util.Date; import java.util.HashMap; import java.util.Map; @@ -537,9 +538,7 @@ public class TarOutputStream extends FilterOutputStream { * An EOF record consists of a record of all zeros. */ private void writeEOFRecord() throws IOException { - for (int i = 0; i < recordBuf.length; ++i) { - recordBuf[i] = 0; - } + Arrays.fill(recordBuf, (byte) 0); buffer.writeRecord(recordBuf); } |