summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Markwalder <tmark@isc.org>2019-03-22 19:10:50 -0400
committerThomas Markwalder <tmark@isc.org>2019-03-22 19:10:50 -0400
commitaef31454468219bf78eaa0528d42b3412dea45ec (patch)
tree2a4b691c82f0e39e95a1e04b0cbfcf29b1f2c231
parentc07eb442990bc5a1f992c91b4d80737562e877bf (diff)
downloadisc-dhcp-2-aftr-name-appears-to-be-wrongly-encoded.tar.gz
[#2,!3] Changed "d" options to "D" options2-aftr-name-appears-to-be-wrongly-encoded
common/tables.c - changed the following options from "d" to "D": DHCPv4: v4-lost v4-access-domain DHCPv6: v6-lost v6-access-domain aftr-name erp-local-domain-name Added a release note.
-rw-r--r--RELNOTES17
-rw-r--r--common/tables.c12
2 files changed, 23 insertions, 6 deletions
diff --git a/RELNOTES b/RELNOTES
index ad9cab2c..1f77a35f 100644
--- a/RELNOTES
+++ b/RELNOTES
@@ -109,6 +109,23 @@ by Eric Young (eay@cryptsoft.com).
this dependency.
[ISC-Bugs #3,!1 git #cc35f84943df44dac2499f3e16e8aaba7d54191d]
+- Several options were changed from option format of "d" which in reality
+ is simply treated as text, to a format of "D" which is RFC 1035 compliant
+ host names. You must now specify these values as single hostname
+ enclosed in quotes. The affected options are:
+
+ DHCPv4:
+ v4-lost
+ v4-access-domain
+ DHCPv6:
+ v6-lost
+ v6-access-domain
+ aftr-name
+ erp-local-domain-name
+
+ Thanks to Jay Doran at BlueCat Networks for reporting this issue.
+ [ISC-Bugs #2,!3 git #TDB]
+
Changes since 4.4.0 (New Features)
- none
Changes since 4.4.0 (Bug Fixes)
diff --git a/common/tables.c b/common/tables.c
index c1aa2145..b8ffe6e7 100644
--- a/common/tables.c
+++ b/common/tables.c
@@ -236,7 +236,7 @@ static struct option dhcp_options[] = {
{"pana-agent", "Ia", &dhcp_universe, 136, 1 },
#endif
#if defined(RFC5223_OPTIONS)
- {"v4-lost", "d", &dhcp_universe, 137, 1 },
+ {"v4-lost", "D", &dhcp_universe, 137, 1 },
#endif
#if defined(RFC5417_OPTIONS)
{"capwap-ac-v4", "Ia", &dhcp_universe, 138, 1 },
@@ -272,7 +272,7 @@ static struct option dhcp_options[] = {
{ "option-6rd", "BB6Ia", &dhcp_universe, 212, 1 },
#endif
#if defined(RFC5986_OPTIONS)
- {"v4-access-domain", "d", &dhcp_universe, 213, 1 },
+ {"v4-access-domain", "D", &dhcp_universe, 213, 1 },
#endif
{ NULL, NULL, NULL, 0, 0 }
};
@@ -497,7 +497,7 @@ static struct option dhcpv6_options[] = {
/* RFC5223 OPTIONS */
#if defined(RFC5223_OPTIONS)
- { "v6-lost", "d", &dhcpv6_universe, 51, 1 },
+ { "v6-lost", "D", &dhcpv6_universe, 51, 1 },
#endif
/* RFC5417 OPTIONS */
@@ -512,7 +512,7 @@ static struct option dhcpv6_options[] = {
/* RFC5986 OPTIONS */
#if defined(RFC5986_OPTIONS)
- { "v6-access-domain", "d", &dhcpv6_universe, 57, 1 },
+ { "v6-access-domain", "D", &dhcpv6_universe, 57, 1 },
#endif
/* RFC6011 OPTIONS */
@@ -530,12 +530,12 @@ static struct option dhcpv6_options[] = {
/* RFC6334 OPTIONS */
#if defined(RFC6334_OPTIONS)
- { "aftr-name", "d", &dhcpv6_universe, 64, 1 },
+ { "aftr-name", "D", &dhcpv6_universe, 64, 1 },
#endif
/* RFC6440 OPTIONS */
#if defined(RFC6440_OPTIONS)
- { "erp-local-domain-name", "d", &dhcpv6_universe, 65, 1 },
+ { "erp-local-domain-name", "D", &dhcpv6_universe, 65, 1 },
#endif
/* RFC6731 OPTIONS */