diff options
| author | Vincent Mailhol <mailhol.vincent@wanadoo.fr> | 2022-10-10 23:16:38 +0900 |
|---|---|---|
| committer | Stephen Hemminger <stephen@networkplumber.org> | 2022-10-17 20:25:12 -0700 |
| commit | 3ab6d5d02f34c75c2547f470c8fe83a59cc9fdeb (patch) | |
| tree | cd762952c195f1833620da4072d44ca857bd54ec /ip | |
| parent | 1ff227545ce1e0e9daf7ecb3eec52ddafff57eb5 (diff) | |
| download | iproute2-3ab6d5d02f34c75c2547f470c8fe83a59cc9fdeb.tar.gz | |
iplink_can: add missing `]' of the bitrate, dbitrate and termination arrays
The command "ip --details link show canX" misses the closing bracket
`]' of the bitrate, the dbitrate and the termination arrays. The --json
output is not impacted.
Change the first argument of close_json_array() from PRINT_JSON to
PRINT_ANY to fix the problem. The second argument was already set
correctly.
Fixes: 67f3c7a5cc0d ("iplink_can: use PRINT_ANY to factorize code and fix signedness")
Reported-by: Marc Kleine-Budde <mkl@pengutronix.de>
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Diffstat (limited to 'ip')
| -rw-r--r-- | ip/iplink_can.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/ip/iplink_can.c b/ip/iplink_can.c index 0e670a6c..9bbe3d95 100644 --- a/ip/iplink_can.c +++ b/ip/iplink_can.c @@ -519,7 +519,7 @@ static void can_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[]) i < bitrate_cnt - 1 ? "%8u, " : "%8u", bitrate_const[i]); } - close_json_array(PRINT_JSON, " ]"); + close_json_array(PRINT_ANY, " ]"); } /* data bittiming is irrelevant if fixed bitrate is defined */ @@ -606,7 +606,7 @@ static void can_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[]) i < dbitrate_cnt - 1 ? "%8u, " : "%8u", dbitrate_const[i]); } - close_json_array(PRINT_JSON, " ]"); + close_json_array(PRINT_ANY, " ]"); } if (tb[IFLA_CAN_TERMINATION_CONST] && tb[IFLA_CAN_TERMINATION]) { @@ -623,7 +623,7 @@ static void can_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[]) print_hu(PRINT_ANY, NULL, i < trm_cnt - 1 ? "%hu, " : "%hu", trm_const[i]); - close_json_array(PRINT_JSON, " ]"); + close_json_array(PRINT_ANY, " ]"); } if (tb[IFLA_CAN_CLOCK]) { |