| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unify the comparison idioms use.
Always use `if(!strcmp())` for "if string equals"
and `if(strcmp())` for "if string is not equal".
Never use `== 0` and `!= 0` with `strcmp()`.
Minor reformatting of the code immediately surrounding the
refactored lines.
Resolves ipmitool/ipmitool#104
Signed-off-by: Alexander Amelkin <alexander@amelkin.msk.ru>
|
| |
|
|
|
|
|
| |
Clean up use of strcmp/strncmp/strncasecmp for command line arguments.
Never use anything but `strcmp()` unless absolutely neccessary.
Partialy resolves ipmitool/ipmitool#104
|
| |
|
|
|
|
|
|
| |
Remove all direct comparisons to 'NULL' for pointers.
Replace them with boolean-like 'if (ptr)' and 'if (!ptr)'.
This makes conditions shorter and easier to read.
Signed-off-by: Alexander Amelkin <alexander@amelkin.msk.ru>
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Make code better readable by replacing `if (rsp->ccode > 0)`
and 'if (rsp->ccode != 0)' with just `if (rsp->ccode)` as
rsp->ccode is anyway an unsigned byte and can't be negative.
Also replace 'if (rsp->ccode == 0)' with 'if (!rsp->ccode)'.
All these changes make lines shorter and easier to read as
a non-zero ccode is an indication of some failure, and so !ccode
naturally reads as 'no error'.
Signed-off-by: Alexander Amelkin <alexander@amelkin.msk.ru>
|
| |
|
|
|
|
| |
Fix misspellings found by codespell in code comments,
console output and documentation.
Resolves ipmitool/ipmitool#28
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
The netfn structures are populated sequentially in the _gather_info
function and they are accessed only by even indices (and to the double
of its real length). This results in a segmentation fault if you run
* ipmitool firewall reset
This patch fixes the behaviour so that the ipmi_firewall_reset function
treats the structure the same way as the rest of the code does.
Signed-off-by: Boris Ranto <branto@redhat.com>
|
| | |
|
| |
|
|
|
| |
Commit fixes comparison of unsigned expression in ipmi_firewall_reset()
and ipmi_firewall_enable_disable().
|
| | |
|
| | |
|
|
|
ipmitool directory.
|
