diff options
| author | Lei YU <yulei.sh@bytedance.com> | 2021-07-13 13:53:09 +0800 |
|---|---|---|
| committer | Alexander Amelkin <mocbuhtig@amelkin.msk.ru> | 2021-07-14 15:27:00 +0300 |
| commit | b7adc1dcafd1f2a3f97063d84176591047bb335e (patch) | |
| tree | dc7882e18c7b2d6b419dbd24b86486144d6967ab | |
| parent | 11c7605c0d5423f90f399f5e830d1095089f38a1 (diff) | |
| download | ipmitool-b7adc1dcafd1f2a3f97063d84176591047bb335e.tar.gz | |
ipmi_mc: Fix the IPM_DEV_FWREV1_MAJOR_MASK
The IPM_DEV_FWREV1_MAJOR_MASK was incorrectly defined as 0x3F.
The spec indicates that the major firmware revision has 0~6 valid bits,
so the mask shall be 0x7F.
Tested: Verify a BMC that has a major version that is large than 0x3F,
and ipmitool shows the correct major version.
Signed-off-by: Lei YU <yulei.sh@bytedance.com>
| -rw-r--r-- | include/ipmitool/ipmi_mc.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/ipmitool/ipmi_mc.h b/include/ipmitool/ipmi_mc.h index 78ceb3d..65cba84 100644 --- a/include/ipmitool/ipmi_mc.h +++ b/include/ipmitool/ipmi_mc.h @@ -83,7 +83,7 @@ struct ipm_devid_rsp { #define IPM_DEV_DEVICE_ID_REV_MASK (0x0F) /* BCD-enoded */ #define IPM_DEV_FWREV1_AVAIL_MASK (0x80) /* 0 = normal operation */ -#define IPM_DEV_FWREV1_MAJOR_MASK (0x3f) /* Major rev, BCD-encoded */ +#define IPM_DEV_FWREV1_MAJOR_MASK (0x7f) /* Major rev, BCD-encoded */ #define IPM_DEV_IPMI_VER_MAJOR_MASK (0x0F) /* Major rev, BCD-encoded */ #define IPM_DEV_IPMI_VER_MINOR_MASK (0xF0) /* Minor rev, BCD-encoded */ |