diff options
| author | Bartosz Nitka <niteria@gmail.com> | 2016-06-02 11:38:11 -0700 |
|---|---|---|
| committer | Bartosz Nitka <niteria@gmail.com> | 2016-06-02 12:49:29 -0700 |
| commit | be4708513fc04dd9c9c99fe652503866ecd85c15 (patch) | |
| tree | 8c1e66e36c6b42d5d275fde5b6280f1ec061465c /compiler | |
| parent | e2446c0d688d63e66fb1ae81cd2ebfa321ebc913 (diff) | |
| download | haskell-be4708513fc04dd9c9c99fe652503866ecd85c15.tar.gz | |
Kill nameSetElems in rnCmdTop
This change isn't necessary for determinism. appAName, choiceAName,
loopAName all have pre-allocated Uniques and their relative order
can't change. I opted to use nameSetElemsStable here because:
* the cost is negligible
* it's less fragile than just documenting
Test Plan: ./validate
Reviewers: simonpj, austin, bgamari, simonmar
Reviewed By: simonmar
Subscribers: thomie
Differential Revision: https://phabricator.haskell.org/D2292
GHC Trac Issues: #4012
Diffstat (limited to 'compiler')
| -rw-r--r-- | compiler/rename/RnExpr.hs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/compiler/rename/RnExpr.hs b/compiler/rename/RnExpr.hs index af58135bcd..32277b43ac 100644 --- a/compiler/rename/RnExpr.hs +++ b/compiler/rename/RnExpr.hs @@ -441,7 +441,7 @@ rnCmdTop = wrapLocFstM rnCmdTop' rnCmdTop' (HsCmdTop cmd _ _ _) = do { (cmd', fvCmd) <- rnLCmd cmd ; let cmd_names = [arrAName, composeAName, firstAName] ++ - nameSetElems (methodNamesCmd (unLoc cmd')) + nameSetElemsStable (methodNamesCmd (unLoc cmd')) -- Generate the rebindable syntax for the monad ; (cmd_names', cmd_fvs) <- lookupSyntaxNames cmd_names |