diff options
| author | François Laignel <fengalin@free.fr> | 2021-04-22 17:53:44 +0200 |
|---|---|---|
| committer | François Laignel <fengalin@free.fr> | 2021-05-04 15:49:32 +0200 |
| commit | 1a8dfdfc54c55f9a431c86847f94b7052d6b6842 (patch) | |
| tree | 6adbabc96265d739fd2e2baca7c76e03d402ff42 /libs | |
| parent | 77ab7b42b382d07982ca8df464e82949dd749612 (diff) | |
| download | gstreamer-1a8dfdfc54c55f9a431c86847f94b7052d6b6842.tar.gz | |
Introduce gst_element_request_pad_simple
The name `gst_element_get_request_pad()` is confusing to people
learning GStreamer. `gst_element_request_pad_simple()` aims at
providing the exact same functionality, while making it more
explicit it is a simplified `gst_element_request_pad()`.
`gst_element_request_pad_simple()` is consistent with other
functions such as `gst_element_seek_simple`.
This commit deprecates `gst_element_get_request_pad()` so that a
compilation warning is emitted when used and incite developers
to use the more explicit `gst_element_request_pad_simple()`.
See also https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/-/merge_requests/743#note_886586
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/802>
Diffstat (limited to 'libs')
| -rw-r--r-- | libs/gst/check/gstcheck.c | 4 | ||||
| -rw-r--r-- | libs/gst/check/gstharness.c | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/libs/gst/check/gstcheck.c b/libs/gst/check/gstcheck.c index 8b6b0ba7ee..123f86e5e3 100644 --- a/libs/gst/check/gstcheck.c +++ b/libs/gst/check/gstcheck.c @@ -596,7 +596,7 @@ gst_check_setup_src_pad_by_name_from_template (GstElement * element, sinkpad = gst_element_get_static_pad (element, name); if (sinkpad == NULL) - sinkpad = gst_element_get_request_pad (element, name); + sinkpad = gst_element_request_pad_simple (element, name); fail_if (sinkpad == NULL, "Could not get sink pad from %s", GST_ELEMENT_NAME (element)); fail_unless (gst_pad_link (srcpad, sinkpad) == GST_PAD_LINK_OK, @@ -721,7 +721,7 @@ gst_check_setup_sink_pad_by_name_from_template (GstElement * element, srcpad = gst_element_get_static_pad (element, name); if (srcpad == NULL) - srcpad = gst_element_get_request_pad (element, name); + srcpad = gst_element_request_pad_simple (element, name); fail_if (srcpad == NULL, "Could not get source pad from %s", GST_ELEMENT_NAME (element)); gst_pad_set_chain_function (sinkpad, gst_check_chain_func); diff --git a/libs/gst/check/gstharness.c b/libs/gst/check/gstharness.c index 0246747e06..7d4b2605f5 100644 --- a/libs/gst/check/gstharness.c +++ b/libs/gst/check/gstharness.c @@ -540,7 +540,7 @@ gst_harness_link_element_srcpad (GstHarness * h, element_srcpad_name); GstPadLinkReturn link; if (srcpad == NULL) - srcpad = gst_element_get_request_pad (h->element, element_srcpad_name); + srcpad = gst_element_request_pad_simple (h->element, element_srcpad_name); g_assert (srcpad); link = gst_pad_link (srcpad, h->sinkpad); g_assert_cmpint (link, ==, GST_PAD_LINK_OK); @@ -559,7 +559,7 @@ gst_harness_link_element_sinkpad (GstHarness * h, element_sinkpad_name); GstPadLinkReturn link; if (sinkpad == NULL) - sinkpad = gst_element_get_request_pad (h->element, element_sinkpad_name); + sinkpad = gst_element_request_pad_simple (h->element, element_sinkpad_name); g_assert (sinkpad); link = gst_pad_link (h->srcpad, sinkpad); g_assert_cmpint (link, ==, GST_PAD_LINK_OK); |