diff options
| author | Tim-Philipp Müller <tim@centricular.com> | 2021-03-03 01:08:25 +0000 |
|---|---|---|
| committer | Tim-Philipp Müller <tim@centricular.com> | 2021-03-15 12:59:56 +0000 |
| commit | b9708e06e1aa7804886c38123e02365cd2b51781 (patch) | |
| tree | 6bf523c35dc7ca32d53e368166606bda674becd0 | |
| parent | 75ab3d8ad1af00ce3f0b61d5fe3ebc5abe53f89f (diff) | |
| download | gstreamer-plugins-base-1.16.tar.gz | |
tag: id3v2: fix frame size check and potential invalid reads1.16
Check the right variable when checking if there's
enough data left to read the frame size.
Closes https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/issues/876
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/1067>
| -rw-r--r-- | gst-libs/gst/tag/id3v2frames.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gst-libs/gst/tag/id3v2frames.c b/gst-libs/gst/tag/id3v2frames.c index 8e9f78254..f39659bf7 100644 --- a/gst-libs/gst/tag/id3v2frames.c +++ b/gst-libs/gst/tag/id3v2frames.c @@ -109,7 +109,7 @@ id3v2_parse_frame (ID3TagsWorking * work) if (work->frame_flags & (ID3V2_FRAME_FORMAT_COMPRESSION | ID3V2_FRAME_FORMAT_DATA_LENGTH_INDICATOR)) { - if (work->hdr.frame_data_size <= 4) + if (frame_data_size <= 4) return FALSE; if (ID3V2_VER_MAJOR (work->hdr.version) == 3) { work->parse_size = GST_READ_UINT32_BE (frame_data); |