diff options
| author | Vincent Penquerc'h <vincent.penquerch@collabora.co.uk> | 2014-06-12 10:14:27 +0100 |
|---|---|---|
| committer | Vincent Penquerc'h <vincent.penquerch@collabora.co.uk> | 2014-06-12 10:18:16 +0100 |
| commit | 402086a82dbfaa85dfaf72aec24df9cf13db82f8 (patch) | |
| tree | dee4364589f6a8d8c3e5798ccddb3800e187a15a /sys | |
| parent | 309395ed4d38fab8c05ba6bae70b1121e892a26c (diff) | |
| download | gstreamer-plugins-bad-402086a82dbfaa85dfaf72aec24df9cf13db82f8.tar.gz | |
dvbsrc: do not try to close negative file descriptors
Interestingly, Coverity implies that close takes an unsigned
argument, while my close(2) man page shows it taking a signed
argument. I guess it may be platforms specific.
Coverity 1214602
Diffstat (limited to 'sys')
| -rw-r--r-- | sys/dvb/gstdvbsrc.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/sys/dvb/gstdvbsrc.c b/sys/dvb/gstdvbsrc.c index 0c18a20d0..f8829d207 100644 --- a/sys/dvb/gstdvbsrc.c +++ b/sys/dvb/gstdvbsrc.c @@ -1974,7 +1974,8 @@ gst_dvbsrc_set_pes_filters (GstDvbSrc * object) fd = &object->fd_filters[i]; pid = object->pids[i]; - close (*fd); + if (*fd >= 0) + close (*fd); if ((*fd = open (demux_dev, O_RDWR)) < 0) { GST_ERROR_OBJECT (object, "Error opening demuxer: %s (%s)", g_strerror (errno), demux_dev); |