diff options
author | Seungha Yang <seungha@centricular.com> | 2021-05-10 20:45:28 +0900 |
---|---|---|
committer | Seungha Yang <seungha@centricular.com> | 2021-06-08 19:39:27 +0900 |
commit | a8ec40c850b678272c279ea4914390ac7abc8408 (patch) | |
tree | ec6fe6075e6ab927876046f3c633c8a25a11c262 /sys/wasapi2/plugin.c | |
parent | 4b42671c9924674e77b8b35f3b22abab651e8bb3 (diff) | |
download | gstreamer-plugins-bad-a8ec40c850b678272c279ea4914390ac7abc8408.tar.gz |
wasapi2: Rewrite plugin and implement audioringbuffer subclass
... based on MediaFoundation work queue API.
By this commit, wasapi2 plugin will make use of pull mode scheduling
with audioringbuffer subclass.
There are several drawbacks of audiosrc/audiosink subclassing
(not audiobasesrc/audiobasesink) for WASAPI API, which are:
* audiosrc/audiosink classes try to set high priority to
read/write thread via MMCSS (Multimedia Class Scheduler Service)
but it's not allowed in case of UWP application.
In order to use MMCSS in UWP, application should use MediaFoundation
work queue indirectly.
Since audiosrc/audiosink scheduling model is not compatible with
MediaFoundation's work queue model, audioringbuffer subclassing
is required.
* WASAPI capture device might report larger packet size than expected
(i.e., larger frames we can read than expected frame size per period).
Meanwhile, in any case, application should drain all packets at that moment.
In order to handle the case, wasapi/wasapi2 plugins were making use of
GstAdapter which is obviously sub-optimal because it requires additional
memory allocation and copy.
By implementing audioringbuffer subclassing, we can avoid such inefficiency.
In this commit, all the device read/write operations will be moved
to newly implemented wasapi2ringbuffer class and
existing wasapi2client class will take care of device enumeration
and activation parts only.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/2306>
Diffstat (limited to 'sys/wasapi2/plugin.c')
-rw-r--r-- | sys/wasapi2/plugin.c | 18 |
1 files changed, 18 insertions, 0 deletions
diff --git a/sys/wasapi2/plugin.c b/sys/wasapi2/plugin.c index 18394ee0a..39cdf4c14 100644 --- a/sys/wasapi2/plugin.c +++ b/sys/wasapi2/plugin.c @@ -26,14 +26,23 @@ #include "gstwasapi2sink.h" #include "gstwasapi2src.h" #include "gstwasapi2device.h" +#include "gstwasapi2util.h" +#include <mfapi.h> GST_DEBUG_CATEGORY (gst_wasapi2_debug); GST_DEBUG_CATEGORY (gst_wasapi2_client_debug); +static void +plugin_deinit (gpointer data) +{ + MFShutdown (); +} + static gboolean plugin_init (GstPlugin * plugin) { GstRank rank = GST_RANK_SECONDARY; + HRESULT hr; /** * plugin-wasapi2: @@ -41,6 +50,11 @@ plugin_init (GstPlugin * plugin) * Since: 1.18 */ + hr = MFStartup (MF_VERSION, MFSTARTUP_NOSOCKET); + if (!gst_wasapi2_result (hr)) { + GST_WARNING ("MFStartup failure, hr: 0x%x", hr); + return TRUE; + } #if WINAPI_FAMILY_PARTITION(WINAPI_PARTITION_APP) && !WINAPI_FAMILY_PARTITION(WINAPI_PARTITION_DESKTOP) /* If we are building for UWP, wasapi2 plugin should have the highest rank */ rank = GST_RANK_PRIMARY + 1; @@ -56,6 +70,10 @@ plugin_init (GstPlugin * plugin) gst_device_provider_register (plugin, "wasapi2deviceprovider", rank, GST_TYPE_WASAPI2_DEVICE_PROVIDER); + g_object_set_data_full (G_OBJECT (plugin), + "plugin-wasapi2-shutdown", "shutdown-data", + (GDestroyNotify) plugin_deinit); + return TRUE; } |