summaryrefslogtreecommitdiff
path: root/src/cmd/internal/browser/browser.go
Commit message (Collapse)AuthorAgeFilesLines
* all: use os/exec instead of internal/execabsRuss Cox2022-05-021-1/+1
| | | | | | | | | | | | | | | | | | | | | We added internal/execabs back in January 2021 in order to fix a security problem caused by os/exec's handling of the current directory. Now that os/exec has that code, internal/execabs is superfluous and can be deleted. This commit rewrites all the imports back to os/exec and deletes internal/execabs. For #43724. Change-Id: Ib9736baf978be2afd42a1225e2ab3fd5d33d19df Reviewed-on: https://go-review.googlesource.com/c/go/+/381375 Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Auto-Submit: Russ Cox <rsc@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
* all: introduce and use internal/execabsRoland Shoemaker2021-01-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | Introduces a wrapper around os/exec, internal/execabs, for use in all commands. This wrapper prevents exec.LookPath and exec.Command from running executables in the current directory. All imports of os/exec in non-test files in cmd/ are replaced with imports of internal/execabs. This issue was reported by RyotaK. Fixes CVE-2021-3115 Fixes #43783 Change-Id: I0423451a6e27ec1e1d6f3fe929ab1ef69145c08f Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/955304 Reviewed-by: Russ Cox <rsc@google.com> Reviewed-by: Katie Hockman <katiehockman@google.com> Reviewed-on: https://go-review.googlesource.com/c/go/+/284783 Run-TryBot: Roland Shoemaker <roland@golang.org> Reviewed-by: Katie Hockman <katie@golang.org> Trust: Roland Shoemaker <roland@golang.org>
* cmd/internal/browser: fix typoKevin Burke2017-02-241-1/+1
| | | | | | Change-Id: I3c31f10c1082c7bc57aac18856014c55f79e0fed Reviewed-on: https://go-review.googlesource.com/37409 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
* cmd/internal/browser: wait 3 seconds for non-zero exit codesChris Broadfoot2017-02-241-1/+19
| | | | | | | | | | | | | | Wait a short period between trying commands. Many commands will return a non-zero exit code if the browser couldn't be launched. For example, google-chrome returns quickly with a non-zero exit code in a headless environment. Updates #19131. Change-Id: I0ae5356dd4447969d9e216615449cead7a8fd5c9 Reviewed-on: https://go-review.googlesource.com/37391 Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
* cmd/internal/browser: use xdg-open only from a desktop sessionChris Broadfoot2017-02-231-1/+4
| | | | | | | | | | | | | xdg-open's man page says: > xdg-open is for use inside a desktop session only. Use the DISPLAY environment variable to detect this. Updates #19131. Change-Id: I3926b3e1042393939b2ec6aacd9b63ac8192df3b Reviewed-on: https://go-review.googlesource.com/37390 Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
* cmd/internal/browser: add chromium to the list of browsersDaniel Martí2016-11-121-1/+6
| | | | | | | | | | Many linux distros distribute Chromium instead of Chrome. Change-Id: I5474d94da28a7c79bdd7181f77472d4ce73bb225 Reviewed-on: https://go-review.googlesource.com/29293 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
* cmd: add internal/browser packageJosh Bleecher Snyder2016-09-141-0/+41
cmd/cover, cmd/trace, and cmd/pprof all open browsers. 'go bug' will soon also open a browser. It is time to unify the browser-handling code. Change-Id: Iee6b443e21e938aeaaac366a1aefb1afbc7d9b2c Reviewed-on: https://go-review.googlesource.com/29160 Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
View Lorry Controller Status