diff options
author | Michael Munday <mike.munday@ibm.com> | 2020-06-18 05:25:07 -0700 |
---|---|---|
committer | Michael Munday <mike.munday@ibm.com> | 2020-06-18 16:36:16 +0000 |
commit | 377c1536f548ae6295699475683db7574bea3d51 (patch) | |
tree | 2d6f7ae735288b5f5e824e8255a5b3f6a11fbea9 /test | |
parent | 4379fa1740b24c610849f597f9ca13711e1bf455 (diff) | |
download | go-git-377c1536f548ae6295699475683db7574bea3d51.tar.gz |
cmd/compile: mark s390x int <-> float conversions as clobbering flags
These conversion instructions set the condition code and so should
be marked as clobbering flags.
Fixes #39651.
Change-Id: I91cc9687ea70ef0551bb3139c1875071c349d43e
Reviewed-on: https://go-review.googlesource.com/c/go/+/238628
Run-TryBot: Michael Munday <mike.munday@ibm.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Diffstat (limited to 'test')
-rw-r--r-- | test/fixedbugs/issue39651.go | 26 |
1 files changed, 26 insertions, 0 deletions
diff --git a/test/fixedbugs/issue39651.go b/test/fixedbugs/issue39651.go new file mode 100644 index 0000000000..256a34dcb3 --- /dev/null +++ b/test/fixedbugs/issue39651.go @@ -0,0 +1,26 @@ +// run + +// Copyright 2020 The Go Authors. All rights reserved. +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +// Test that float -> integer conversion doesn't clobber +// flags. + +package main + +//go:noinline +func f(x, y float64, a, b *bool, r *int64) { + *a = x < y // set flags + *r = int64(x) // clobber flags + *b = x == y // use flags +} + +func main() { + var a, b bool + var r int64 + f(1, 1, &a, &b, &r) + if a || !b { + panic("comparison incorrect") + } +} |