diff options
| author | Keith Randall <keithr@alum.mit.edu> | 2018-09-07 14:55:09 -0700 |
|---|---|---|
| committer | Keith Randall <khr@golang.org> | 2018-10-03 19:54:16 +0000 |
| commit | 9a8372f8bd5a39d2476bfa9247407b51f9193b9e (patch) | |
| tree | c8383f43af15466e5320044f5910c55073c41592 /test/fixedbugs/issue20250.go | |
| parent | cbafcc55e80d5b444e659a892b739c04a27980d3 (diff) | |
| download | go-git-9a8372f8bd5a39d2476bfa9247407b51f9193b9e.tar.gz | |
cmd/compile,runtime: remove ambiguously live logic
The previous CL introduced stack objects. This CL removes the old
ambiguously live liveness analysis. After this CL we're relying
on stack objects exclusively.
Update a bunch of liveness tests to reflect the new world.
Fixes #22350
Change-Id: I739b26e015882231011ce6bc1a7f426049e59f31
Reviewed-on: https://go-review.googlesource.com/c/134156
Reviewed-by: Austin Clements <austin@google.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Diffstat (limited to 'test/fixedbugs/issue20250.go')
| -rw-r--r-- | test/fixedbugs/issue20250.go | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/test/fixedbugs/issue20250.go b/test/fixedbugs/issue20250.go index 6fc861a8dc..47879385d2 100644 --- a/test/fixedbugs/issue20250.go +++ b/test/fixedbugs/issue20250.go @@ -15,10 +15,10 @@ type T struct { } func f(a T) { // ERROR "live at entry to f: a" - var e interface{} - func() { // ERROR "live at entry to f.func1: a &e" - e = a.s // ERROR "live at call to convT2Estring: a &e" - }() // ERROR "live at call to f.func1: e$" + var e interface{} // ERROR "stack object e interface \{\}$" + func() { // ERROR "live at entry to f.func1: a &e" + e = a.s // ERROR "live at call to convT2Estring: &e" "stack object a T$" + }() // Before the fix, both a and e were live at the previous line. _ = e } |