diff options
author | Dmitriy Vyukov <dvyukov@google.com> | 2013-07-01 17:36:08 -0400 |
---|---|---|
committer | Russ Cox <rsc@golang.org> | 2013-07-01 17:36:08 -0400 |
commit | fd23958f49f0967c9a5999ffc2e33740f246a11a (patch) | |
tree | 5b08e4b8b266c064c90be0652ca4974bae9f9b67 /test/deferfin.go | |
parent | 20498ed772ef5791a17248f1198b58265299574e (diff) | |
download | go-git-fd23958f49f0967c9a5999ffc2e33740f246a11a.tar.gz |
runtime: fix memory leaks due to defers
fn can clearly hold a closure in memory.
argp/pc point into stack and so can hold
in memory a block that was previously
a large stack serment.
R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/10784043
Diffstat (limited to 'test/deferfin.go')
-rw-r--r-- | test/deferfin.go | 59 |
1 files changed, 59 insertions, 0 deletions
diff --git a/test/deferfin.go b/test/deferfin.go new file mode 100644 index 0000000000..f9a74eba9c --- /dev/null +++ b/test/deferfin.go @@ -0,0 +1,59 @@ +// run + +// Copyright 2013 The Go Authors. All rights reserved. +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +// Test that defers do not prevent garbage collection. + +package main + +import ( + "runtime" + "sync" + "sync/atomic" + "time" +) + +var sink func() + +func main() { + // Does not work on 32-bits due to partially conservative GC. + // Try to enable when we have fully precise GC. + if runtime.GOARCH != "amd64" { + return + } + N := 10 + count := int32(N) + var wg sync.WaitGroup + wg.Add(N) + for i := 0; i < N; i++ { + go func() { + defer wg.Done() + v := new(int) + f := func() { + if *v != 0 { + panic("oops") + } + } + if *v != 0 { + // let the compiler think f escapes + sink = f + } + runtime.SetFinalizer(v, func(p *int) { + atomic.AddInt32(&count, -1) + }) + defer f() + }() + } + wg.Wait() + for i := 0; i < 3; i++ { + time.Sleep(10 * time.Millisecond) + runtime.GC() + } + if count != 0 { + println(count, "out of", N, "finalizer are not called") + panic("not all finalizers are called") + } +} + |