diff options
author | Russ Cox <rsc@golang.org> | 2011-11-13 22:58:08 -0500 |
---|---|---|
committer | Russ Cox <rsc@golang.org> | 2011-11-13 22:58:08 -0500 |
commit | 5bb54b8e9cd810d378397bae464f8933509e62bc (patch) | |
tree | cc49af668faa74c1f3eb55e3978e14844bc1bbc0 /test/cmp6.go | |
parent | efb74460c366286cf17225874c7d6333542647bc (diff) | |
download | go-git-5bb54b8e9cd810d378397bae464f8933509e62bc.tar.gz |
gc: remove func, map compare
R=ken, ken
CC=golang-dev
https://golang.org/cl/5373079
Diffstat (limited to 'test/cmp6.go')
-rw-r--r-- | test/cmp6.go | 28 |
1 files changed, 18 insertions, 10 deletions
diff --git a/test/cmp6.go b/test/cmp6.go index b3ea8ffebf..6b13cac236 100644 --- a/test/cmp6.go +++ b/test/cmp6.go @@ -11,7 +11,7 @@ func use(bool) {} type T1 *int type T2 *int -type T3 struct {} +type T3 struct{} var t3 T3 @@ -21,12 +21,12 @@ func main() { // so chan int can be compared against // directional channels but channel of different // direction cannot be compared against each other. - var c1 chan <-int + var c1 chan<- int var c2 <-chan int var c3 chan int - - use(c1 == c2) // ERROR "invalid operation|incompatible" - use(c2 == c1) // ERROR "invalid operation|incompatible" + + use(c1 == c2) // ERROR "invalid operation|incompatible" + use(c2 == c1) // ERROR "invalid operation|incompatible" use(c1 == c3) use(c2 == c2) use(c3 == c1) @@ -36,14 +36,22 @@ func main() { var p1 T1 var p2 T2 var p3 *int - - use(p1 == p2) // ERROR "invalid operation|incompatible" - use(p2 == p1) // ERROR "invalid operation|incompatible" + + use(p1 == p2) // ERROR "invalid operation|incompatible" + use(p2 == p1) // ERROR "invalid operation|incompatible" use(p1 == p3) use(p2 == p2) use(p3 == p1) use(p3 == p2) - + // Comparison of structs should have a good message - use(t3 == t3) // ERROR "struct|expected" + use(t3 == t3) // ERROR "struct|expected" + + // Slices, functions, and maps too. + var x []int + var f func() + var m map[int]int + use(x == x) // ERROR "slice can only be compared to nil" + use(f == f) // ERROR "func can only be compared to nil" + use(m == m) // ERROR "map can only be compared to nil" } |