diff options
| author | Russ Cox <rsc@golang.org> | 2017-03-31 12:46:35 -0400 |
|---|---|---|
| committer | Russ Cox <rsc@golang.org> | 2017-04-03 14:01:25 +0000 |
| commit | 719c7b03ba5d8bdea937a6b21564fa82539d3661 (patch) | |
| tree | 27c4c5af043d8e62ab1e4bb5d264df0d09f23a21 /src/time/format_test.go | |
| parent | 65c17a05e98866d1e29a5d53fc21b0221760698d (diff) | |
| download | go-git-719c7b03ba5d8bdea937a6b21564fa82539d3661.tar.gz | |
testing/quick: generate all possible int64, uint64 values
When generating a random int8, uint8, int16, uint16, int32, uint32,
quick.Value chooses among all possible values.
But when generating a random int64 or uint64, it only chooses
values in the range [-2⁶², 2⁶²) (even for uint64).
It should, like for all the other integers, use the full range.
If it had, this would have caught #19807 earlier.
Instead it let us discover the presence of #19809.
While we are here, also make the default source of
randomness not completely deterministic.
Fixes #19808.
Change-Id: I070f852531c92b3670bd76523326c9132bfc9416
Reviewed-on: https://go-review.googlesource.com/39152
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rob Pike <r@golang.org>
Diffstat (limited to 'src/time/format_test.go')
| -rw-r--r-- | src/time/format_test.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/time/format_test.go b/src/time/format_test.go index d0013bc3e3..710de594a0 100644 --- a/src/time/format_test.go +++ b/src/time/format_test.go @@ -378,8 +378,8 @@ func checkTime(time Time, test *ParseTest, t *testing.T) { func TestFormatAndParse(t *testing.T) { const fmt = "Mon MST " + RFC3339 // all fields f := func(sec int64) bool { - t1 := Unix(sec, 0) - if t1.Year() < 1000 || t1.Year() > 9999 { + t1 := Unix(sec/2, 0) + if t1.Year() < 1000 || t1.Year() > 9999 || t1.Unix() != sec { // not required to work return true } |