diff options
| author | Russ Cox <rsc@golang.org> | 2016-05-25 14:37:43 -0400 |
|---|---|---|
| committer | Russ Cox <rsc@golang.org> | 2016-05-26 19:02:00 +0000 |
| commit | 7fdec6216c0a25c6dbcc8159b755da6682dd9080 (patch) | |
| tree | bf489c761706e04d64ef73675ceb805c4b30a3c4 /src/runtime/stack.go | |
| parent | 2168f2a68bb438996d14869ff7dd10a47cc0552c (diff) | |
| download | go-git-7fdec6216c0a25c6dbcc8159b755da6682dd9080.tar.gz | |
build: enable framepointer mode by default
This has a minor performance cost, but far less than is being gained by SSA.
As an experiment, enable it during the Go 1.7 beta.
Having frame pointers on by default makes Linux's perf, Intel VTune,
and other profilers much more useful, because it lets them gather a
stack trace efficiently on profiling events.
(It doesn't help us that much, since when we walk the stack we usually
need to look up PC-specific information as well.)
Fixes #15840.
Change-Id: I4efd38412a0de4a9c87b1b6e5d11c301e63f1a2a
Reviewed-on: https://go-review.googlesource.com/23451
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'src/runtime/stack.go')
| -rw-r--r-- | src/runtime/stack.go | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/runtime/stack.go b/src/runtime/stack.go index 33d29f19a8..8e344cdf03 100644 --- a/src/runtime/stack.go +++ b/src/runtime/stack.go @@ -155,9 +155,6 @@ var stackLarge struct { free [_MHeapMap_Bits]mSpanList // free lists by log_2(s.npages) } -// Cached value of haveexperiment("framepointer") -var framepointer_enabled bool - func stackinit() { if _StackCacheSize&_PageMask != 0 { throw("cache size must be a multiple of page size") |