diff options
| author | Austin Clements <austin@google.com> | 2015-06-15 12:30:23 -0400 |
|---|---|---|
| committer | Austin Clements <austin@google.com> | 2015-06-19 15:29:50 +0000 |
| commit | f5d494bbdf945f2662eb4da45cdb75de2b7d43d4 (patch) | |
| tree | 980019bcd3379b225e7f4d9c231f837cd3511dd6 /src/runtime/asm_arm.s | |
| parent | 75ce33068d8c2c45f40e599ae2d4c80cb8b919d7 (diff) | |
| download | go-git-f5d494bbdf945f2662eb4da45cdb75de2b7d43d4.tar.gz | |
runtime: ensure GC sees type-safe memory on weak machines
Currently its possible for the garbage collector to observe
uninitialized memory or stale heap bitmap bits on weakly ordered
architectures such as ARM and PPC. On such architectures, the stores
that zero newly allocated memory and initialize its heap bitmap may
move after a store in user code that makes the allocated object
observable by the garbage collector.
To fix this, add a "publication barrier" (also known as an "export
barrier") before returning from mallocgc. This is a store/store
barrier that ensures any write done by user code that makes the
returned object observable to the garbage collector will be ordered
after the initialization performed by mallocgc. No barrier is
necessary on the reading side because of the data dependency between
loading the pointer and loading the contents of the object.
Fixes one of the issues raised in #9984.
Change-Id: Ia3d96ad9c5fc7f4d342f5e05ec0ceae700cd17c8
Reviewed-on: https://go-review.googlesource.com/11083
Reviewed-by: Rick Hudson <rlh@golang.org>
Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
Reviewed-by: Minux Ma <minux@golang.org>
Reviewed-by: Martin Capitanio <capnm9@gmail.com>
Reviewed-by: Russ Cox <rsc@golang.org>
Diffstat (limited to 'src/runtime/asm_arm.s')
| -rw-r--r-- | src/runtime/asm_arm.s | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/src/runtime/asm_arm.s b/src/runtime/asm_arm.s index 874dc4fe55..661538c024 100644 --- a/src/runtime/asm_arm.s +++ b/src/runtime/asm_arm.s @@ -736,6 +736,17 @@ TEXT runtime·atomicloaduint(SB),NOSPLIT,$0-8 TEXT runtime·atomicstoreuintptr(SB),NOSPLIT,$0-8 B runtime·atomicstore(SB) +// armPublicationBarrier is a native store/store barrier for ARMv7+. +// To implement publiationBarrier in sys_$GOOS_arm.s using the native +// instructions, use: +// +// TEXT ·publicationBarrier(SB),NOSPLIT,$-4-0 +// B runtime·armPublicationBarrier(SB) +// +TEXT runtime·armPublicationBarrier(SB),NOSPLIT,$-4-0 + WORD $0xf57ff05e // DMB ST + RET + // AES hashing not implemented for ARM TEXT runtime·aeshash(SB),NOSPLIT,$-4-0 MOVW $0, R0 |