summaryrefslogtreecommitdiff
path: root/src/reflect
diff options
context:
space:
mode:
authorCuong Manh Le <cuong.manhle.vn@gmail.com>2022-08-27 22:08:09 +0700
committerCuong Manh Le <cuong.manhle.vn@gmail.com>2022-08-30 00:37:15 +0000
commit47f8db368cbb1971f386717ae7c76a1891a6130c (patch)
tree636e3b9e5394977c5346383ed82811b6404af04e /src/reflect
parent65535581aaf5441b68d8d31d3f338df4042f1972 (diff)
downloadgo-git-47f8db368cbb1971f386717ae7c76a1891a6130c.tar.gz
reflect: clarify Value.Equal behavior for non-comparable values
The current implementation always returns false for non-comparable values, update the doc to reflect that. Change-Id: I87f2da408874b0a209c8f51949e3310da15c5904 Reviewed-on: https://go-review.googlesource.com/c/go/+/426195 Reviewed-by: Ian Lance Taylor <iant@google.com> Reviewed-by: xie cui <523516579@qq.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: hopehook <hopehook@golangcn.org> Reviewed-by: Heschi Kreinick <heschi@google.com> Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com> Reviewed-by: Cherry Mui <cherryyz@google.com>
Diffstat (limited to 'src/reflect')
-rw-r--r--src/reflect/value.go1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/reflect/value.go b/src/reflect/value.go
index 061545bd4f..3611a5a66c 100644
--- a/src/reflect/value.go
+++ b/src/reflect/value.go
@@ -3309,6 +3309,7 @@ func (v Value) Comparable() bool {
}
// Equal reports true if v is equal to u.
+// For valid values, if either v or u is non-comparable, Equal returns false.
func (v Value) Equal(u Value) bool {
if !v.IsValid() || !u.IsValid() {
return v.IsValid() == u.IsValid()