diff options
| author | Russ Cox <rsc@golang.org> | 2023-04-19 16:05:37 -0400 |
|---|---|---|
| committer | Russ Cox <rsc@golang.org> | 2023-04-20 14:56:22 +0000 |
| commit | 4f9a966926e2537c435e60e75e5c866374be07e7 (patch) | |
| tree | 56764cd136df360f3f0fdeb557c992192e006153 /src/go/types | |
| parent | b4b70a4617fa318ae3e3f3b3d1bb9241d4dc0f9e (diff) | |
| download | go-git-4f9a966926e2537c435e60e75e5c866374be07e7.tar.gz | |
go/types: fix version downgrade bug without Config.GoVersion
The gVisor team reported a regression in their checkers,
which don't set Config.GoVersion, processing files that say
//go:build go1.13 but still use 'any' (which happened in Go 1.18).
That situation should continue to work, since it worked before,
so add a special case for not knowing the GoVersion.
Change-Id: I8820d8ccbdf76d304e2c7e45f6aaa993ff3d16a6
Reviewed-on: https://go-review.googlesource.com/c/go/+/486398
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@google.com>
Diffstat (limited to 'src/go/types')
| -rw-r--r-- | src/go/types/api.go | 2 | ||||
| -rw-r--r-- | src/go/types/check.go | 5 |
2 files changed, 5 insertions, 2 deletions
diff --git a/src/go/types/api.go b/src/go/types/api.go index a144462968..7af84fd244 100644 --- a/src/go/types/api.go +++ b/src/go/types/api.go @@ -116,7 +116,7 @@ type Config struct { // GoVersion describes the accepted Go language version. The string // must follow the format "go%d.%d" (e.g. "go1.12") or it must be - // empty; an empty string indicates the latest language version. + // empty; an empty string disables Go language version checks. // If the format is invalid, invoking the type checker will cause a // panic. GoVersion string diff --git a/src/go/types/check.go b/src/go/types/check.go index 58cf6d060c..5381b5db68 100644 --- a/src/go/types/check.go +++ b/src/go/types/check.go @@ -302,7 +302,10 @@ func (check *Checker) initFiles(files []*ast.File) { // build lines were ignored and code got the module's Go version. // To work around this, downgrades are only allowed when the // module's Go version is Go 1.21 or later. - if v.before(check.version) && check.version.before(version{1, 21}) { + // If there is no check.version, then we don't really know what Go version to apply. + // Legacy tools may do this, and they historically have accepted everything. + // Preserve that behavior by ignoring //go:build constraints entirely in that case. + if (v.before(check.version) && check.version.before(version{1, 21})) || check.version.equal(version{0, 0}) { continue } if check.posVers == nil { |