diff options
| author | Brad Fitzpatrick <bradfitz@golang.org> | 2016-04-03 01:34:29 +0000 |
|---|---|---|
| committer | Brad Fitzpatrick <bradfitz@golang.org> | 2016-04-03 06:20:37 +0000 |
| commit | 0656da910a1750921961b0955f9150f326199847 (patch) | |
| tree | 1b5d059c02e62b78cd56f833442e92e8ed39d357 /src/fmt | |
| parent | 163ff700b8ac3192fa1cb1424e5facf060683dd2 (diff) | |
| download | go-git-0656da910a1750921961b0955f9150f326199847.tar.gz | |
fmt: hold on to all free buffers, regardless of size
This code made sense before fmt switched to using sync.Pool, but a
sync.Pool clears all items on GC, so not reusing something based on
size is just a waste of memory.
Change-Id: I201312b0ee6c572ff3c0ffaf71e42623a160d23f
Reviewed-on: https://go-review.googlesource.com/21480
Reviewed-by: Rob Pike <r@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'src/fmt')
| -rw-r--r-- | src/fmt/print.go | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/src/fmt/print.go b/src/fmt/print.go index 1a0b51a5a9..d071dcfb31 100644 --- a/src/fmt/print.go +++ b/src/fmt/print.go @@ -132,10 +132,6 @@ func newPrinter() *pp { // free saves used pp structs in ppFree; avoids an allocation per invocation. func (p *pp) free() { - // Don't hold on to pp structs with large buffers. - if cap(p.buf) > 1024 { - return - } p.buf = p.buf[:0] p.arg = nil p.value = reflect.Value{} |