summaryrefslogtreecommitdiff
path: root/src/cmd/link/internal/ld/dwarf_test.go
diff options
context:
space:
mode:
authorAlex Brainman <alex.brainman@gmail.com>2020-04-26 10:40:38 +1000
committerAlex Brainman <alex.brainman@gmail.com>2020-04-30 08:07:47 +0000
commitc76befe0f40dfbb38a54c16d1845b97e4580797c (patch)
tree6d4435935bb20f4e548796c672f4d408d50018ce /src/cmd/link/internal/ld/dwarf_test.go
parent5c9a8c0761ae643828a4526db764ac7a50a1a24d (diff)
downloadgo-git-c76befe0f40dfbb38a54c16d1845b97e4580797c.tar.gz
cmd/go: use -buildmode=pie as default on window
This change adjusts go command to pass -buildmode=pie to cmd/link, if -buildmode is not explicitly provided. Fixes #35192 Change-Id: Iec020131e676eb3e9a2df9eea1929b2af2b6df04 Reviewed-on: https://go-review.googlesource.com/c/go/+/230217 Run-TryBot: Alex Brainman <alex.brainman@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
Diffstat (limited to 'src/cmd/link/internal/ld/dwarf_test.go')
-rw-r--r--src/cmd/link/internal/ld/dwarf_test.go9
1 files changed, 7 insertions, 2 deletions
diff --git a/src/cmd/link/internal/ld/dwarf_test.go b/src/cmd/link/internal/ld/dwarf_test.go
index cf6bec8053..a1c8496eea 100644
--- a/src/cmd/link/internal/ld/dwarf_test.go
+++ b/src/cmd/link/internal/ld/dwarf_test.go
@@ -924,8 +924,8 @@ func TestRuntimeTypeAttrInternal(t *testing.T) {
t.Skip("skipping on plan9; no DWARF symbol table in executables")
}
- if runtime.GOOS == "windows" && runtime.GOARCH == "arm" {
- t.Skip("skipping on windows/arm; test is incompatible with relocatable binaries")
+ if runtime.GOOS == "windows" {
+ t.Skip("skipping on windows; test is incompatible with relocatable binaries")
}
testRuntimeTypeAttr(t, "-ldflags=-linkmode=internal")
@@ -944,6 +944,11 @@ func TestRuntimeTypeAttrExternal(t *testing.T) {
if runtime.GOARCH == "ppc64" {
t.Skip("-linkmode=external not supported on ppc64")
}
+
+ if runtime.GOOS == "windows" {
+ t.Skip("skipping on windows; test is incompatible with relocatable binaries")
+ }
+
testRuntimeTypeAttr(t, "-ldflags=-linkmode=external")
}