diff options
| author | Rob Pike <r@golang.org> | 2015-01-23 11:24:42 -0800 |
|---|---|---|
| committer | Rob Pike <r@golang.org> | 2015-01-24 03:28:26 +0000 |
| commit | 89162307cd2ddf0a514d3a3ed9f7b94e45f1cb15 (patch) | |
| tree | ceff0b5c05581907f57c1b4701ae0a71ddc2965c /src/cmd/asm/main.go | |
| parent | 07a27ce09ea01c1939389d5f5e1d3414fc893882 (diff) | |
| download | go-git-89162307cd2ddf0a514d3a3ed9f7b94e45f1cb15.tar.gz | |
[dev.cc] cmd/asm: changes to get identical output as new6a
Fix up a couple of minor things pointed out in the last review.
Also:
1. If the symbol starts with center dot, prefix the name with "".
2. If there is no locals size specified, use ArgsSizeUnknown (sic).
3. Do not emit a history point at the start of a macro invocation,
since we do not pop it at the end, behavior consistent with the
old code.
With these changes, old and new assemblers produce identical
output at least for my simple test case, so that provides a verifiable
check for future cleanups.
Change-Id: Iaa91d8e453109824b4be44321ec5e828f39f0299
Reviewed-on: https://go-review.googlesource.com/3242
Reviewed-by: Russ Cox <rsc@golang.org>
Diffstat (limited to 'src/cmd/asm/main.go')
| -rw-r--r-- | src/cmd/asm/main.go | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/cmd/asm/main.go b/src/cmd/asm/main.go index 08354119a6..3c02d4eebd 100644 --- a/src/cmd/asm/main.go +++ b/src/cmd/asm/main.go @@ -30,8 +30,7 @@ func main() { log.Fatalf("asm: unrecognized architecture %s", GOARCH) } - // Is this right? - flags.Parse(build.Default.GOROOT, build.Default.GOOS, GOARCH, architecture.Thechar) + flags.Parse(obj.Getgoroot(), obj.Getgoos(), obj.Getgoarch(), architecture.Thechar) // Create object file, write header. fd, err := os.Create(*flags.OutputFile) |