diff options
| author | Joe Tsai <joetsai@digital-static.net> | 2023-01-18 10:22:54 -0800 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2023-01-18 19:59:26 +0000 |
| commit | 9894ded19417fbc40420dc813d3c6606348ad31b (patch) | |
| tree | c2f0821ed75854e62494cd27157f1543ac5abf89 /doc | |
| parent | 6fcbd0369d3ac9002e2b46229f90ce64ce0539e4 (diff) | |
| download | go-git-9894ded19417fbc40420dc813d3c6606348ad31b.tar.gz | |
time: revert strict parsing of RFC 3339
CL 444277 fixed Time.UnmarshalText and Time.UnmarshalJSON to properly
unmarshal timestamps according to RFC 3339 instead of according
to Go's bespoke time syntax that is a superset of RFC 3339.
However, this change seems to have broken an AWS S3 unit test
that relies on parsing timestamps with single digit hours.
It is unclear whether S3 emits these timestamps in production or
whether this is simply a testing artifact that has been cargo culted
across many code bases. Either way, disable strict parsing for now
and re-enable later with better GODEBUG support.
Updates #54580
Change-Id: Icced2c7f9a6b2fc06bbd9c7e90f90edce24c2306
Reviewed-on: https://go-review.googlesource.com/c/go/+/462286
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Joseph Tsai <joetsai@digital-static.net>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Russ Cox <rsc@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/go1.20.html | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/doc/go1.20.html b/doc/go1.20.html index 324d59ed6e..1fef45204e 100644 --- a/doc/go1.20.html +++ b/doc/go1.20.html @@ -1200,9 +1200,8 @@ proxyHandler := &httputil.ReverseProxy{ </p> <p><!-- CL 444277 --> - The <a href="/pkg/time/#Time.MarshalJSON"><code>Time.MarshalJSON</code></a> and - <a href="/pkg/time/#Time.UnmarshalJSON"><code>Time.UnmarshalJSON</code></a> methods - are now more strict about adherence to RFC 3339. + The <a href="/pkg/time/#Time.MarshalJSON"><code>Time.MarshalJSON</code></a> method + is now more strict about adherence to RFC 3339. </p> </dd> </dl><!-- time --> |