diff options
| author | Matthew Dempsky <mdempsky@google.com> | 2022-08-11 10:20:09 -0700 |
|---|---|---|
| committer | Matthew Dempsky <mdempsky@google.com> | 2022-08-11 20:03:02 +0000 |
| commit | 72a857a2802a60ae99000efa2cf6e629d75deb4c (patch) | |
| tree | 998f907d3db0f406006877e852206c38ae0601b2 | |
| parent | 0337fc7e0e084adeea58f333a8aa7dbc43363baf (diff) | |
| download | go-git-72a857a2802a60ae99000efa2cf6e629d75deb4c.tar.gz | |
test: relax fixedbugs/issue20250.go expectations
With GOEXPERIMENT=unified, the order variables are printed in "live at
entry to f.func1" is sensitive to whether regabi is enabled for some
reason. The order shouldn't matter to correctness, but it is odd.
For now, this CL just relaxes the test expectation order to unblock
enabling GOEXPERIMENT=unified by default. I've filed #54402 to
investigate further to confirm this a concern.
Updates #54402.
Change-Id: Iddfbb12c6cf7cc17b2aec8102b33761abd5f93ad
Reviewed-on: https://go-review.googlesource.com/c/go/+/422975
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
| -rw-r--r-- | test/fixedbugs/issue20250.go | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/test/fixedbugs/issue20250.go b/test/fixedbugs/issue20250.go index aed7b25d1b..7c6e796e8e 100644 --- a/test/fixedbugs/issue20250.go +++ b/test/fixedbugs/issue20250.go @@ -16,7 +16,9 @@ type T struct { func f(a T) { // ERROR "live at entry to f: a" var e interface{} // ERROR "stack object e interface \{\}$" - func() { // ERROR "live at entry to f.func1: a &e" + // TODO(go.dev/issue/54402): Investigate why "live at entry to + // f.func1" is sensitive to regabi. + func() { // ERROR "live at entry to f.func1: (a &e|&e a)" e = a.s // ERROR "live at call to convT: &e" "stack object a T$" }() // Before the fix, both a and e were live at the previous line. |