diff options
| author | Daniel Martà <mvdan@mvdan.cc> | 2023-01-09 12:46:20 +0000 |
|---|---|---|
| committer | Daniel Martà <mvdan@mvdan.cc> | 2023-01-20 09:27:21 +0000 |
| commit | 1bef0707a537d19bbbfda09dde05e5874a2fb199 (patch) | |
| tree | b675528ece11d34099bc5e81fd24b152ee95d109 | |
| parent | 8354f6b5bb5baf03cb64dbf736c276f297ebea96 (diff) | |
| download | go-git-1bef0707a537d19bbbfda09dde05e5874a2fb199.tar.gz | |
cmd/link: use strings.LastIndexByte to fix a TODO
Go 1.20 will require Go 1.17 to bootstrap, so we can stop worrying about
older Go bootstrap versions. https://go.dev/issues/44505 fixed most of
those TODOs, but this one was presumably forgotten about.
Change-Id: I0c19ec4eec65cd807e7db9a57c5969845d915c07
Reviewed-on: https://go-review.googlesource.com/c/go/+/461155
Reviewed-by: Than McIntosh <thanm@google.com>
Run-TryBot: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
| -rw-r--r-- | src/cmd/link/internal/ld/pcln.go | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/src/cmd/link/internal/ld/pcln.go b/src/cmd/link/internal/ld/pcln.go index 34ab86cf12..b18a2b4bd4 100644 --- a/src/cmd/link/internal/ld/pcln.go +++ b/src/cmd/link/internal/ld/pcln.go @@ -297,11 +297,7 @@ func (state *pclntab) generateFuncnametab(ctxt *Link, funcs []loader.Sym) map[lo if i < 0 { return name, "", "" } - // TODO: use LastIndexByte once the bootstrap compiler is >= Go 1.5. - j := len(name) - 1 - for j > i && name[j] != ']' { - j-- - } + j := strings.LastIndexByte(name, ']') if j <= i { return name, "", "" } |