summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPatrik Lundin <patrik@sigterm.se>2019-07-04 22:48:23 +0000
committerEmmanuel Odeke <emm.odeke@gmail.com>2019-07-05 00:26:14 +0000
commit04e2e81ecbb6a34863cb46f22d7b8f434c8b852f (patch)
treef84dfacff16bcfd7b4600364a61ff4a7c6ba1cc9
parentadcb2b1e7aef2d06ec19cad52f24e8271a12d26a (diff)
downloadgo-git-04e2e81ecbb6a34863cb46f22d7b8f434c8b852f.tar.gz
net/http: stop ExampleServer_Shutdown from hanging on error
Running the example code when not having permissions to bind to port 80 will cause the program to hang after printing the error message. Change-Id: I2433ba2629b362fc8f1731e40cab5eea72ec354f GitHub-Last-Rev: 0bb3dc08b6f646470fc6ff208ea12bca901a2299 GitHub-Pull-Request: golang/go#32947 Reviewed-on: https://go-review.googlesource.com/c/go/+/185157 Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com> Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
-rw-r--r--src/net/http/example_test.go2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/net/http/example_test.go b/src/net/http/example_test.go
index 2a09f5f6c6..a783b46618 100644
--- a/src/net/http/example_test.go
+++ b/src/net/http/example_test.go
@@ -132,7 +132,7 @@ func ExampleServer_Shutdown() {
if err := srv.ListenAndServe(); err != http.ErrServerClosed {
// Error starting or closing listener:
- log.Printf("HTTP server ListenAndServe: %v", err)
+ log.Fatalf("HTTP server ListenAndServe: %v", err)
}
<-idleConnsClosed