summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBastien Nocera <hadess@hadess.net>2022-03-28 17:45:08 +0200
committerBastien Nocera <hadess@hadess.net>2022-03-28 18:02:08 +0200
commitb4d739c8644d2bdd639ef045ebc8c6fa155c7d86 (patch)
tree3c5b8208d2ae69eb541380b13105fa67786b770d
parentad00c21901ed18ab161e160cc910af9dd50230a0 (diff)
downloadlibrest-b4d739c8644d2bdd639ef045ebc8c6fa155c7d86.tar.gz
ci: Use upstream check-abi
-rw-r--r--.gitlab-ci.yml3
-rwxr-xr-x.gitlab-ci/check-abi113
2 files changed, 2 insertions, 114 deletions
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 944bb27..862ba19 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -29,7 +29,8 @@ build-librest:
- meson _build -Dexamples=true
- ninja -C _build
- bash +x ./.gitlab-ci/run-tests.sh
- - ./.gitlab-ci/check-abi ${LAST_ABI_BREAK} $(git rev-parse HEAD)
+ - curl https://gitlab.freedesktop.org/hadess/check-abi/-/raw/main/contrib/check-abi-fedora.sh | bash
+ - check-abi ${LAST_ABI_BREAK} $(git rev-parse HEAD)
artifacts:
reports:
junit: "_build/${CI_JOB_NAME}-report.xml"
diff --git a/.gitlab-ci/check-abi b/.gitlab-ci/check-abi
deleted file mode 100755
index fc2296d..0000000
--- a/.gitlab-ci/check-abi
+++ /dev/null
@@ -1,113 +0,0 @@
-#!/usr/bin/python3
-
-
-import argparse
-import contextlib
-import os
-import shutil
-import subprocess
-import sys
-
-
-def format_title(title):
- box = {
- 'tl': '╔', 'tr': '╗', 'bl': '╚', 'br': '╝', 'h': '═', 'v': '║',
- }
- hline = box['h'] * (len(title) + 2)
-
- return '\n'.join([
- f"{box['tl']}{hline}{box['tr']}",
- f"{box['v']} {title} {box['v']}",
- f"{box['bl']}{hline}{box['br']}",
- ])
-
-
-def rm_rf(path):
- try:
- shutil.rmtree(path)
- except FileNotFoundError:
- pass
-
-
-def sanitize_path(name):
- return name.replace('/', '-')
-
-
-def get_current_revision():
- revision = subprocess.check_output(['git', 'rev-parse', '--abbrev-ref', 'HEAD'],
- encoding='utf-8').strip()
-
- if revision == 'HEAD':
- # This is a detached HEAD, get the commit hash
- revision = subprocess.check_output(['git', 'rev-parse', 'HEAD']).strip().decode('utf-8')
-
- return revision
-
-
-@contextlib.contextmanager
-def checkout_git_revision(revision):
- current_revision = get_current_revision()
- subprocess.check_call(['git', 'checkout', '-q', revision])
-
- try:
- yield
- finally:
- subprocess.check_call(['git', 'checkout', '-q', current_revision])
-
-
-def build_install(revision):
- build_dir = '_build'
- dest_dir = os.path.abspath(sanitize_path(revision))
- print(format_title(f'# Building and installing {revision} in {dest_dir}'),
- end='\n\n', flush=True)
-
- with checkout_git_revision(revision):
- rm_rf(build_dir)
- rm_rf(revision)
-
- subprocess.check_call(['meson', build_dir,
- '--prefix=/usr', '--libdir=lib',
- '-Db_coverage=false', '-Dgtk_doc=false', '-Dtests=false', '-Dexamples=false'])
- subprocess.check_call(['ninja', '-v', '-C', build_dir])
- subprocess.check_call(['ninja', '-v', '-C', build_dir, 'install'],
- env={'DESTDIR': dest_dir})
-
- return dest_dir
-
-
-def compare(old_tree, new_tree):
- print(format_title(f'# Comparing the two ABIs'), end='\n\n', flush=True)
-
- old_headers = os.path.join(old_tree, 'usr', 'include')
- old_lib = os.path.join(old_tree, 'usr', 'lib', 'librest-1.0.so')
-
- new_headers = os.path.join(new_tree, 'usr', 'include')
- new_lib = os.path.join(new_tree, 'usr', 'lib', 'librest-1.0.so')
-
- subprocess.check_call([
- 'abidiff', '--headers-dir1', old_headers, '--headers-dir2', new_headers,
- '--drop-private-types', '--fail-no-debug-info', '--no-added-syms', old_lib, new_lib])
-
-if __name__ == '__main__':
- parser = argparse.ArgumentParser()
-
- parser.add_argument('old', help='the previous revision, considered the reference')
- parser.add_argument('new', help='the new revision, to compare to the reference')
-
- args = parser.parse_args()
-
- if args.old == args.new:
- print("Let's not waste time comparing something to itself")
- sys.exit(0)
-
- old_tree = build_install(args.old)
- new_tree = build_install(args.new)
-
- try:
- compare(old_tree, new_tree)
-
- except Exception as e:
- print ('ABI comparison failed: '+ str(e))
- sys.exit(1)
-
- print(f'Hurray! {args.old} and {args.new} are ABI-compatible!')