| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
This restriction was already in place, since we passed the inputs
directly to GLib functions that expect valid UTF8.
If this library were widely used then we might proactively validate
inputs to protect against exploits. At time of writing, this module is
only used in 3 places (grilo-plugins, gnome-music and rygel), so just
check they are doing the right thing when calling the API.
See https://gitlab.gnome.org/GNOME/libmediaart/-/merge_requests/5 for
background.
|
| |
|
|
|
|
|
|
|
|
|
| |
We return NULL if input is NULL and a newly allocated empty string if
input is "". Some comments disagreed with this, and it's possible the
change causes a memory leak in some app, but the alternative of returning
NULL when passed "" is dangerous as some code may free the return value
in this case. (In fact, libmediaart itself does so).
Also, make behaviour occur independently of whether
`G_ENABLE_CONSISTENCY_CHECKS` was defined at build time.
|
| |
|
|
|
|
|
| |
This is deemed quite useless now and we should not be littering the file
system with .mediaartlocal directories everywhere.
https://bugzilla.gnome.org/show_bug.cgi?id=722795
|
| | |
|
| |
|
|
|
|
|
|
| |
Part of this API changes makes the media_art_get_{path|file}() APIs not do
i/o operations like creating the cache directory. This is now done in
media_art_process_new().
https://bugzilla.gnome.org/show_bug.cgi?id=724879
|
| |
|
|
|
|
|
|
|
| |
The function media_art_get_file checks for null values in artist, title and
prefix arguments, and puts special values on them if they do.
Do the same on media_art_get_path which calls media_art_get_file internally.
https://bugzilla.gnome.org/show_bug.cgi?id=727478
|
| |
|
|
|
|
|
| |
Also added some checks into the API and a return value to know if the function
was successful.
https://bugzilla.gnome.org/show_bug.cgi?id=734837
|
| |
|
|
|
|
|
| |
This is quite an API break, but the previous API was confusing and a monster,
so this was really necessary.
The unit tests have been put in place to make sure things work correctly too.
|
| | |
|
| |
|
|
|
|
| |
Add more information to documentation.
Add a check on the input string to make sure we avoid crashes.
Add test case
|
| |
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=723847
|
| |
|
|
|
| |
There are many cases which fail and there are FIXMEs in the test case now
which we should fix before releasing.
|
| | |
|
| |
|
|
|
|
|
| |
This call is similar to media_art_get_path(), but using GFiles
for in/out path parameters. This older function now internally
uses the just added one, so internally operations happen on
GFiles.
|
| | |
|
| | |
|
| | |
|
| |
|
