summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFlorian Müllner <fmuellner@gnome.org>2023-03-08 19:27:27 +0100
committerMarge Bot <marge-bot@gnome.org>2023-04-25 10:45:19 +0000
commita1f8f2efa18cd1022bca6894bbfb8e19165a9e98 (patch)
tree968252362c024d866b284fb8424e131de151dfe1
parent65ec7b3fa894fc7e8412e18f80767b178aa84549 (diff)
downloadgnome-shell-a1f8f2efa18cd1022bca6894bbfb8e19165a9e98.tar.gz
portalHelper: Remove pointless destroyWindow() method
Years ago, the function used to clean up the cache when the window was closed. But now that an ephemeral data manager is used, nothing is cached anymore and the function is left as a mere wrapper around this.destroy(). Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2690>
-rw-r--r--js/portalHelper/main.js9
1 files changed, 2 insertions, 7 deletions
diff --git a/js/portalHelper/main.js b/js/portalHelper/main.js
index cdf8b51cc..62a522e51 100644
--- a/js/portalHelper/main.js
+++ b/js/portalHelper/main.js
@@ -116,7 +116,6 @@ class PortalWindow extends Gtk.ApplicationWindow {
_init(application, url, timestamp, doneCallback) {
super._init({ application });
- this.connect('delete-event', this.destroyWindow.bind(this));
this._headerBar = new PortalHeaderBar();
this._headerBar.setSecurityIcon(PortalHelperSecurityLevel.NOT_YET_DETERMINED);
this.set_titlebar(this._headerBar);
@@ -161,10 +160,6 @@ class PortalWindow extends Gtk.ApplicationWindow {
this.application.set_accels_for_action('app.quit', ['<Primary>q', '<Primary>w']);
}
- destroyWindow() {
- this.destroy();
- }
-
_syncUri() {
let uri = this._webView.uri;
if (uri)
@@ -293,7 +288,7 @@ class WebPortalHelper extends Gtk.Application {
this._queue = [];
let action = new Gio.SimpleAction({ name: 'quit' });
- action.connect('activate', () => this.active_window.destroyWindow());
+ action.connect('activate', () => this.active_window.destroy());
this.add_action(action);
}
@@ -326,7 +321,7 @@ class WebPortalHelper extends Gtk.Application {
if (obj.connection == connection) {
if (obj.window)
- obj.window.destroyWindow();
+ obj.window.destroy();
this._queue.splice(i, 1);
break;
}