summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorrobert.mader@collabora.com <robert.mader@collabora.com>2023-02-20 18:07:23 +0100
committerJonas Dreßler <verdre@v0yd.nl>2023-04-25 20:28:28 +0200
commit46517e02dd4dc640893bc819dd549f04b04b61ea (patch)
tree4ff0622319bb4978c14f786ec3c788a01e599676
parentcad01d154c3da966d9679bd1dbf7f030416c2911 (diff)
downloadgnome-shell-46517e02dd4dc640893bc819dd549f04b04b61ea.tar.gz
screencastService: Drop always-copy condition
The check for the Pipewire version was originally introduced in d32c0348 which states: > Since it is not clear yet when a proper solution will arrive, > this makes use of `always-copy` as a workaround for now and > should be reverted once it is no longer needed. The check for a stable Gstreamer version with the mention proper fix was introduced in d7b44319 and carried for the 43 cycle. By the time Gnome 44 will be released all distros should have had enough time to update their Gstreamer version - or backport the patches, in case of not ustream-supported versions. Thus lets drop it now. Note: `always-copy` is not suitable for dmabuf buffers as it copies via mmap. Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2609>
-rw-r--r--js/dbusServices/screencast/screencastService.js4
1 files changed, 0 insertions, 4 deletions
diff --git a/js/dbusServices/screencast/screencastService.js b/js/dbusServices/screencast/screencastService.js
index 32af1e320..85410231f 100644
--- a/js/dbusServices/screencast/screencastService.js
+++ b/js/dbusServices/screencast/screencastService.js
@@ -316,13 +316,9 @@ var Recorder = class {
_ensurePipeline(nodeId) {
const framerate = this._framerate;
- const needsCopy =
- Gst.Registry.get().check_feature_version('pipewiresrc', 0, 3, 57) &&
- !Gst.Registry.get().check_feature_version('videoconvert', 1, 20, 4);
let fullPipeline = `
pipewiresrc path=${nodeId}
- always-copy=${needsCopy}
do-timestamp=true
keepalive-time=1000
resend-last=true !