diff options
| author | Ray Strode <rstrode@redhat.com> | 2022-12-15 14:46:01 -0500 |
|---|---|---|
| committer | Ray Strode <rstrode@redhat.com> | 2022-12-15 14:58:29 -0500 |
| commit | 10df58d8c42f7b47a9e7be54219958c8afdd0322 (patch) | |
| tree | 1a37bda5ed5d8c5b3d1ce647802beaf0540c3572 /src | |
| parent | ae2c426800c3f2d462047cd59691382d083925dd (diff) | |
| download | gnome-online-accounts-10df58d8c42f7b47a9e7be54219958c8afdd0322.tar.gz | |
kerberos-identity: Unbreak handling of fresh caches
commit 4acfcc323e986526975ede981673dd173be4e267 attempted to
avoid an error variable getting stomped all over by returning
FALSE when encountering the error.
Unfortunately, it's actual legitimate for an error to happen
in that path and we should proceed anyway.
That can happen when a credential cache is new and not yet
initialized, so it won't have a principal associated with it
yet.
This commit changes the problematic code to just pass NULL
for the error variable, since we don't need it.
Diffstat (limited to 'src')
| -rw-r--r-- | src/goaidentity/goakerberosidentity.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/src/goaidentity/goakerberosidentity.c b/src/goaidentity/goakerberosidentity.c index 55288d2..a20c043 100644 --- a/src/goaidentity/goakerberosidentity.c +++ b/src/goaidentity/goakerberosidentity.c @@ -1121,11 +1121,10 @@ goa_kerberos_identity_initable_init (GInitable *initable, if (self->identifier == NULL) { - self->identifier = get_identifier (self, error); - if (self->identifier == NULL) - return FALSE; + self->identifier = get_identifier (self, NULL); - queue_notify (self, &self->identifier_idle_id, "identifier"); + if (self->identifier != NULL) + queue_notify (self, &self->identifier_idle_id, "identifier"); } verification_error = NULL; |