summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorvelsinki <112010-velsinki@users.noreply.gitlab.gnome.org>2023-03-30 00:44:43 +0200
committervelsinki <112010-velsinki@users.noreply.gitlab.gnome.org>2023-04-03 08:46:36 +0000
commite61b270fb7b2ad005b4424f7b02ed9024cf05962 (patch)
tree53074a12c4cc768258c957d2dcc8092fe19fa3ec
parent2dc7aa1206b02f77dbe47c4e605e6bdcd56ce2a4 (diff)
downloadgnome-control-center-e61b270fb7b2ad005b4424f7b02ed9024cf05962.tar.gz
sharing: Fix network row visible name bug
In `cc_sharing_networks_new_row`, the `network_name` is not being set to the new row, but to `self->current_row`. This is incorrect behavior, as it leaves the new row without any title, and overwrites the title of the current row incorrectly to the last network entry in the enabled networks list. This fix correctly sets the name to the new row instead. This problem is at least discussed in #2318 (point 3) and causes some confusion in #2299 as well.
-rw-r--r--panels/sharing/cc-sharing-networks.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/panels/sharing/cc-sharing-networks.c b/panels/sharing/cc-sharing-networks.c
index 7ce77b135..7b977f585 100644
--- a/panels/sharing/cc-sharing-networks.c
+++ b/panels/sharing/cc-sharing-networks.c
@@ -214,7 +214,7 @@ cc_sharing_networks_new_row (const char *uuid,
}
adw_action_row_set_icon_name (ADW_ACTION_ROW (row), icon_name);
- adw_preferences_row_set_title (ADW_PREFERENCES_ROW (self->current_row), network_name);
+ adw_preferences_row_set_title (ADW_PREFERENCES_ROW (row), network_name);
/* Remove button */
w = gtk_button_new_from_icon_name ("window-close-symbolic");